Add case sensitivity diff suppression for enums. (#8626) (#15491)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/8626.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+containeraws: added diff suppression for case changes of enum values in `google_container_aws_cluster` and `google_container_aws_node_pool`
+```

google/services/containeraws/resource_container_aws_cluster.go

@@ -391,11 +391,12 @@ func ContainerAwsClusterControlPlaneMainVolumeSchema() *schema.Resource {
 			},
 
 			"volume_type": {
-				Type:        schema.TypeString,
-				Computed:    true,
-				Optional:    true,
-				ForceNew:    true,
-				Description: "Optional. Type of the EBS volume. When unspecified, it defaults to GP2 volume. Possible values: VOLUME_TYPE_UNSPECIFIED, GP2, GP3",
+				Type:             schema.TypeString,
+				Computed:         true,
+				Optional:         true,
+				ForceNew:         true,
+				DiffSuppressFunc: tpgresource.CompareCaseInsensitive,
+				Description:      "Optional. Type of the EBS volume. When unspecified, it defaults to GP2 volume. Possible values: VOLUME_TYPE_UNSPECIFIED, GP2, GP3",
 			},
 		},
 	}
@@ -450,10 +451,11 @@ func ContainerAwsClusterControlPlaneRootVolumeSchema() *schema.Resource {
 			},
 
 			"volume_type": {
-				Type:        schema.TypeString,
-				Computed:    true,
-				Optional:    true,
-				Description: "Optional. Type of the EBS volume. When unspecified, it defaults to GP2 volume. Possible values: VOLUME_TYPE_UNSPECIFIED, GP2, GP3",
+				Type:             schema.TypeString,
+				Computed:         true,
+				Optional:         true,
+				DiffSuppressFunc: tpgresource.CompareCaseInsensitive,
+				Description:      "Optional. Type of the EBS volume. When unspecified, it defaults to GP2 volume. Possible values: VOLUME_TYPE_UNSPECIFIED, GP2, GP3",
 			},
 		},
 	}

google/services/containeraws/resource_container_aws_cluster_generated_test.go

@@ -77,6 +77,50 @@ func TestAccContainerAwsCluster_BasicHandWritten(t *testing.T) {
 		},
 	})
 }
+func TestAccContainerAwsCluster_BasicEnumHandWritten(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"aws_acct_id":    "111111111111",
+		"aws_db_key":     "00000000-0000-0000-0000-17aad2f0f61f",
+		"aws_region":     "us-west-2",
+		"aws_sg":         "sg-0b3f63cb91b247628",
+		"aws_subnet":     "subnet-0b3f63cb91b247628",
+		"aws_vol_key":    "00000000-0000-0000-0000-17aad2f0f61f",
+		"aws_vpc":        "vpc-0b3f63cb91b247628",
+		"byo_prefix":     "mmv2",
+		"project_name":   envvar.GetTestProjectFromEnv(),
+		"project_number": envvar.GetTestProjectNumberFromEnv(),
+		"service_acct":   envvar.GetTestServiceAccountFromEnv(t),
+		"random_suffix":  acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckContainerAwsClusterDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccContainerAwsCluster_BasicEnumHandWritten(context),
+			},
+			{
+				ResourceName:            "google_container_aws_cluster.primary",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"fleet.0.project"},
+			},
+			{
+				Config: testAccContainerAwsCluster_BasicEnumHandWrittenUpdate0(context),
+			},
+			{
+				ResourceName:            "google_container_aws_cluster.primary",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"fleet.0.project"},
+			},
+		},
+	})
+}
 
 func testAccContainerAwsCluster_BasicHandWritten(context map[string]interface{}) string {
 	return acctest.Nprintf(`
@@ -255,6 +299,186 @@ resource "google_container_aws_cluster" "primary" {
 }
 
 
+`, context)
+}
+
+func testAccContainerAwsCluster_BasicEnumHandWritten(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+data "google_container_aws_versions" "versions" {
+  project = "%{project_name}"
+  location = "us-west1"
+}
+
+resource "google_container_aws_cluster" "primary" {
+  authorization {
+    admin_users {
+      username = "%{service_acct}"
+    }
+  }
+
+  aws_region = "%{aws_region}"
+
+  control_plane {
+    aws_services_authentication {
+      role_arn          = "arn:aws:iam::%{aws_acct_id}:role/%{byo_prefix}-1p-dev-oneplatform"
+      role_session_name = "%{byo_prefix}-1p-dev-session"
+    }
+
+    config_encryption {
+      kms_key_arn = "arn:aws:kms:%{aws_region}:%{aws_acct_id}:key/%{aws_db_key}"
+    }
+
+    database_encryption {
+      kms_key_arn = "arn:aws:kms:%{aws_region}:%{aws_acct_id}:key/%{aws_db_key}"
+    }
+
+    iam_instance_profile = "%{byo_prefix}-1p-dev-controlplane"
+    subnet_ids           = ["%{aws_subnet}"]
+    version   = "${data.google_container_aws_versions.versions.valid_versions[0]}"
+    instance_type        = "t3.medium"
+
+    main_volume {
+      iops        = 3000
+      kms_key_arn = "arn:aws:kms:%{aws_region}:%{aws_acct_id}:key/%{aws_vol_key}"
+      size_gib    = 10
+      volume_type = "gp3"
+    }
+
+    proxy_config {
+      secret_arn     = "arn:aws:secretsmanager:us-west-2:126285863215:secret:proxy_config20210824150329476300000001-ABCDEF"
+      secret_version = "12345678-ABCD-EFGH-IJKL-987654321098"
+    }
+
+    root_volume {
+      iops        = 3000
+      kms_key_arn = "arn:aws:kms:%{aws_region}:%{aws_acct_id}:key/%{aws_vol_key}"
+      size_gib    = 10
+      volume_type = "gp3"
+    }
+
+    security_group_ids = ["%{aws_sg}"]
+
+    ssh_config {
+      ec2_key_pair = "%{byo_prefix}-1p-dev-ssh"
+    }
+
+    tags = {
+      owner = "%{service_acct}"
+    }
+  }
+
+  fleet {
+    project = "%{project_number}"
+  }
+
+  location = "us-west1"
+  name     = "tf-test-name%{random_suffix}"
+
+  networking {
+    pod_address_cidr_blocks     = ["10.2.0.0/16"]
+    service_address_cidr_blocks = ["10.1.0.0/16"]
+    vpc_id                      = "%{aws_vpc}"
+  }
+
+  annotations = {
+    label-one = "value-one"
+  }
+
+  description = "A sample aws cluster"
+  project     = "%{project_name}"
+}
+
+
+`, context)
+}
+
+func testAccContainerAwsCluster_BasicEnumHandWrittenUpdate0(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+data "google_container_aws_versions" "versions" {
+  project = "%{project_name}"
+  location = "us-west1"
+}
+
+resource "google_container_aws_cluster" "primary" {
+  authorization {
+    admin_users {
+      username = "%{service_acct}"
+    }
+  }
+
+  aws_region = "%{aws_region}"
+
+  control_plane {
+    aws_services_authentication {
+      role_arn          = "arn:aws:iam::%{aws_acct_id}:role/%{byo_prefix}-1p-dev-oneplatform"
+      role_session_name = "%{byo_prefix}-1p-dev-session"
+    }
+
+    config_encryption {
+      kms_key_arn = "arn:aws:kms:%{aws_region}:%{aws_acct_id}:key/%{aws_db_key}"
+    }
+
+    database_encryption {
+      kms_key_arn = "arn:aws:kms:%{aws_region}:%{aws_acct_id}:key/%{aws_db_key}"
+    }
+
+    iam_instance_profile = "%{byo_prefix}-1p-dev-controlplane"
+    subnet_ids           = ["%{aws_subnet}"]
+    version   = "${data.google_container_aws_versions.versions.valid_versions[0]}"
+    instance_type        = "t3.medium"
+
+    main_volume {
+      iops        = 3000
+      kms_key_arn = "arn:aws:kms:%{aws_region}:%{aws_acct_id}:key/%{aws_vol_key}"
+      size_gib    = 10
+      volume_type = "gp3"
+    }
+
+    proxy_config {
+      secret_arn     = "arn:aws:secretsmanager:us-west-2:126285863215:secret:proxy_config20210824150329476300000001-ABCDEF"
+      secret_version = "12345678-ABCD-EFGH-IJKL-987654321098"
+    }
+
+    root_volume {
+      iops        = 3000
+      kms_key_arn = "arn:aws:kms:%{aws_region}:%{aws_acct_id}:key/%{aws_vol_key}"
+      size_gib    = 10
+      volume_type = "gp3"
+    }
+
+    security_group_ids = ["%{aws_sg}"]
+
+    ssh_config {
+      ec2_key_pair = "%{byo_prefix}-1p-dev-ssh"
+    }
+
+    tags = {
+      owner = "%{service_acct}"
+    }
+  }
+
+  fleet {
+    project = "%{project_number}"
+  }
+
+  location = "us-west1"
+  name     = "tf-test-name%{random_suffix}"
+
+  networking {
+    pod_address_cidr_blocks     = ["10.2.0.0/16"]
+    service_address_cidr_blocks = ["10.1.0.0/16"]
+    vpc_id                      = "%{aws_vpc}"
+  }
+
+  annotations = {
+    label-two = "value-two"
+  }
+
+  description = "An updated sample aws cluster"
+  project     = "%{project_name}"
+}
+
+
 `, context)
 }
 

google/services/containeraws/resource_container_aws_node_pool.go

@@ -356,10 +356,11 @@ func ContainerAwsNodePoolConfigRootVolumeSchema() *schema.Resource {
 			},
 
 			"volume_type": {
-				Type:        schema.TypeString,
-				Computed:    true,
-				Optional:    true,
-				Description: "Optional. Type of the EBS volume. When unspecified, it defaults to GP2 volume. Possible values: VOLUME_TYPE_UNSPECIFIED, GP2, GP3",
+				Type:             schema.TypeString,
+				Computed:         true,
+				Optional:         true,
+				DiffSuppressFunc: tpgresource.CompareCaseInsensitive,
+				Description:      "Optional. Type of the EBS volume. When unspecified, it defaults to GP2 volume. Possible values: VOLUME_TYPE_UNSPECIFIED, GP2, GP3",
 			},
 		},
 	}
@@ -381,10 +382,11 @@ func ContainerAwsNodePoolConfigTaintsSchema() *schema.Resource {
 	return &schema.Resource{
 		Schema: map[string]*schema.Schema{
 			"effect": {
-				Type:        schema.TypeString,
-				Required:    true,
-				ForceNew:    true,
-				Description: "The taint effect. Possible values: EFFECT_UNSPECIFIED, NO_SCHEDULE, PREFER_NO_SCHEDULE, NO_EXECUTE",
+				Type:             schema.TypeString,
+				Required:         true,
+				ForceNew:         true,
+				DiffSuppressFunc: tpgresource.CompareCaseInsensitive,
+				Description:      "The taint effect. Possible values: EFFECT_UNSPECIFIED, NO_SCHEDULE, PREFER_NO_SCHEDULE, NO_EXECUTE",
 			},
 
 			"key": {