vpc access connector use self_link or name (#5623) (#10988)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/5623.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+vpc_access_connector: Updated field `network` to accept self_link or name
+```

google/resource_vpc_access_connector.go

@@ -70,11 +70,12 @@ func resourceVPCAccessConnector() *schema.Resource {
 				Default:      200,
 			},
 			"network": {
-				Type:         schema.TypeString,
-				Optional:     true,
-				ForceNew:     true,
-				Description:  `Name of the VPC network. Required if 'ip_cidr_range' is set.`,
-				ExactlyOneOf: []string{"network"},
+				Type:             schema.TypeString,
+				Optional:         true,
+				ForceNew:         true,
+				DiffSuppressFunc: compareResourceNames,
+				Description:      `Name or self_link of the VPC network. Required if 'ip_cidr_range' is set.`,
+				ExactlyOneOf:     []string{"network"},
 			},
 			"region": {
 				Type:        schema.TypeString,
@@ -362,7 +363,10 @@ func flattenVPCAccessConnectorName(v interface{}, d *schema.ResourceData, config
 }
 
 func flattenVPCAccessConnectorNetwork(v interface{}, d *schema.ResourceData, config *Config) interface{} {
-	return v
+	if v == nil {
+		return v
+	}
+	return NameFromSelfLinkStateFunc(v)
 }
 
 func flattenVPCAccessConnectorIpCidrRange(v interface{}, d *schema.ResourceData, config *Config) interface{} {
@@ -412,7 +416,7 @@ func expandVPCAccessConnectorName(v interface{}, d TerraformResourceData, config
 }
 
 func expandVPCAccessConnectorNetwork(v interface{}, d TerraformResourceData, config *Config) (interface{}, error) {
-	return v, nil
+	return GetResourceNameFromSelfLink(v.(string)), nil
 }
 
 func expandVPCAccessConnectorIpCidrRange(v interface{}, d TerraformResourceData, config *Config) (interface{}, error) {

website/docs/r/vpc_access_connector.html.markdown

@@ -179,7 +179,7 @@ The following arguments are supported:
 
 * `network` -
   (Optional)
-  Name of the VPC network. Required if `ip_cidr_range` is set.
+  Name or self_link of the VPC network. Required if `ip_cidr_range` is set.
 
 * `ip_cidr_range` -
   (Optional)