add day_offset field to google_os_config_patch_deployment.recurring_schedule.monthly.week_day_of_month (#9016) (#15997)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/9016.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+osconfig: added `week_day_of_month.day_offset` field to the `google_os_config_patch_deployment` resource
+```

google/services/osconfig/resource_os_config_patch_deployment.go

@@ -818,6 +818,13 @@ will not run in February, April, June, etc.`,
 													ValidateFunc: validation.IntBetween(-1, 4),
 													Description:  `Week number in a month. 1-4 indicates the 1st to 4th week of the month. -1 indicates the last week of the month.`,
 												},
+												"day_offset": {
+													Type:         schema.TypeInt,
+													Optional:     true,
+													ForceNew:     true,
+													ValidateFunc: validation.IntBetween(-30, 30),
+													Description:  `Represents the number of days before or after the given week day of month that the patch deployment is scheduled for.`,
+												},
 											},
 										},
 										ExactlyOneOf: []string{"recurring_schedule.0.monthly.0.week_day_of_month", "recurring_schedule.0.monthly.0.month_day"},
@@ -1977,6 +1984,8 @@ func flattenOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonth(v inte
 		flattenOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthWeekOrdinal(original["weekOrdinal"], d, config)
 	transformed["day_of_week"] =
 		flattenOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthDayOfWeek(original["dayOfWeek"], d, config)
+	transformed["day_offset"] =
+		flattenOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthDayOffset(original["dayOffset"], d, config)
 	return []interface{}{transformed}
 }
 func flattenOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthWeekOrdinal(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
@@ -2000,6 +2009,23 @@ func flattenOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthDayOfWe
 	return v
 }
 
+func flattenOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthDayOffset(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	// Handles the string fixed64 format
+	if strVal, ok := v.(string); ok {
+		if intVal, err := tpgresource.StringToFixed64(strVal); err == nil {
+			return intVal
+		}
+	}
+
+	// number values are represented as float64
+	if floatVal, ok := v.(float64); ok {
+		intVal := int(floatVal)
+		return intVal
+	}
+
+	return v // let terraform core handle it otherwise
+}
+
 func flattenOSConfigPatchDeploymentRecurringScheduleMonthlyMonthDay(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	// Handles the string fixed64 format
 	if strVal, ok := v.(string); ok {
@@ -3228,6 +3254,13 @@ func expandOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonth(v inter
 		transformed["dayOfWeek"] = transformedDayOfWeek
 	}
 
+	transformedDayOffset, err := expandOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthDayOffset(original["day_offset"], d, config)
+	if err != nil {
+		return nil, err
+	} else if val := reflect.ValueOf(transformedDayOffset); val.IsValid() && !tpgresource.IsEmptyValue(val) {
+		transformed["dayOffset"] = transformedDayOffset
+	}
+
 	return transformed, nil
 }
 
@@ -3239,6 +3272,10 @@ func expandOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthDayOfWee
 	return v, nil
 }
 
+func expandOSConfigPatchDeploymentRecurringScheduleMonthlyWeekDayOfMonthDayOffset(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandOSConfigPatchDeploymentRecurringScheduleMonthlyMonthDay(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
 	return v, nil
 }

google/services/osconfig/resource_os_config_patch_deployment_generated_test.go

@@ -383,6 +383,7 @@ resource "google_os_config_patch_deployment" "patch" {
       week_day_of_month {
         week_ordinal = -1
         day_of_week  = "TUESDAY"
+        day_offset   = 3
       }
     }
   }

website/docs/r/os_config_patch_deployment.html.markdown

@@ -284,6 +284,7 @@ resource "google_os_config_patch_deployment" "patch" {
       week_day_of_month {
         week_ordinal = -1
         day_of_week  = "TUESDAY"
+        day_offset   = 3
       }
     }
   }
@@ -801,6 +802,10 @@ The following arguments are supported:
   A day of the week.
   Possible values are: `MONDAY`, `TUESDAY`, `WEDNESDAY`, `THURSDAY`, `FRIDAY`, `SATURDAY`, `SUNDAY`.
 
+* `day_offset` -
+  (Optional)
+  Represents the number of days before or after the given week day of month that the patch deployment is scheduled for.
+
 <a name="nested_rollout"></a>The `rollout` block supports:
 
 * `mode` -