Add support for creating a memcached instance that uses a specific IP address range (#9670) (#17101)

* Update Instance.yaml

Add support for creating a memcached instance that uses a specific IP address range.

* Add support for creating a memcached instance that uses a specific IP address range

Add support for creating a memcached instance that uses a specific IP address range.
Github issue - [https://github.com/hashicorp/terraform-provider-google/issues/16819](https://www.google.com/url?q=https://github.com/hashicorp/terraform-provider-google/issues/16819&sa=D&source=buganizer&usg=AOvVaw0idc98DoPRr2rVXo0ACl0V)

* Update Instance.yaml

reservedIpRangeId is used for intial creation only so keeping ignore_read and removing is_set , default_from_api

* Update resource_memcache_instance_test.go

Update test for reserved_ip_range_id field

* Update resource_memcache_instance_test.go

ignore output only fields in update test to fix testAccMemcacheInstance_update

* Update resource_memcache_instance_test.go

Resolved the formatting errors.
[upstream:bd70fcd3fa470cc6c19efc755a78f3cd43c1f592]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/9670.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+memcache: added `reserved_ip_range_id` field to `google_memcache_instance` resource
+```

google/services/memcache/resource_memcache_instance.go

@@ -250,6 +250,17 @@ determined by our system based on the latest supported minor version. Default va
 				ForceNew:    true,
 				Description: `The region of the Memcache instance. If it is not provided, the provider region is used.`,
 			},
+			"reserved_ip_range_id": {
+				Type:     schema.TypeList,
+				Optional: true,
+				ForceNew: true,
+				Description: `Contains the name of allocated IP address ranges associated with
+the private service access connection for example, "test-default"
+associated with IP range 10.0.0.0/29.`,
+				Elem: &schema.Schema{
+					Type: schema.TypeString,
+				},
+			},
 			"zones": {
 				Type:     schema.TypeSet,
 				Computed: true,
@@ -422,6 +433,12 @@ func resourceMemcacheInstanceCreate(d *schema.ResourceData, meta interface{}) er
 	} else if v, ok := d.GetOkExists("maintenance_policy"); !tpgresource.IsEmptyValue(reflect.ValueOf(maintenancePolicyProp)) && (ok || !reflect.DeepEqual(v, maintenancePolicyProp)) {
 		obj["maintenancePolicy"] = maintenancePolicyProp
 	}
+	reservedIpRangeIdProp, err := expandMemcacheInstanceReservedIpRangeId(d.Get("reserved_ip_range_id"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("reserved_ip_range_id"); !tpgresource.IsEmptyValue(reflect.ValueOf(reservedIpRangeIdProp)) && (ok || !reflect.DeepEqual(v, reservedIpRangeIdProp)) {
+		obj["reservedIpRangeId"] = reservedIpRangeIdProp
+	}
 	labelsProp, err := expandMemcacheInstanceEffectiveLabels(d.Get("effective_labels"), d, config)
 	if err != nil {
 		return err
@@ -1445,6 +1462,10 @@ func expandMemcacheInstanceMaintenancePolicyWeeklyMaintenanceWindowStartTimeNano
 	return v, nil
 }
 
+func expandMemcacheInstanceReservedIpRangeId(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandMemcacheInstanceEffectiveLabels(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (map[string]string, error) {
 	if v == nil {
 		return map[string]string{}, nil

google/services/memcache/resource_memcache_instance_generated_test.go

@@ -50,7 +50,7 @@ func TestAccMemcacheInstance_memcacheInstanceBasicTestExample(t *testing.T) {
 				ResourceName:            "google_memcache_instance.instance",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"name", "region", "labels", "terraform_labels"},
+				ImportStateVerifyIgnore: []string{"name", "reserved_ip_range_id", "region", "labels", "terraform_labels"},
 			},
 		},
 	})

google/services/memcache/resource_memcache_instance_test.go

@@ -26,9 +26,10 @@ func TestAccMemcacheInstance_update(t *testing.T) {
 				Config: testAccMemcacheInstance_update(prefix, name, network),
 			},
 			{
-				ResourceName:      "google_memcache_instance.test",
-				ImportState:       true,
-				ImportStateVerify: true,
+				ResourceName:            "google_memcache_instance.test",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"reserved_ip_range_id"},
 			},
 			{
 				Config: testAccMemcacheInstance_update2(prefix, name, network),
@@ -61,6 +62,7 @@ resource "google_memcache_instance" "test" {
       "max-item-size" = "8388608"
     }
   }
+  reserved_ip_range_id = ["tf-bootstrap-addr-memcache-instance-update-1"]
 }
 
 data "google_compute_network" "memcache_network" {

website/docs/r/memcache_instance.html.markdown

@@ -159,6 +159,12 @@ The following arguments are supported:
   Maintenance policy for an instance.
   Structure is [documented below](#nested_maintenance_policy).
 
+* `reserved_ip_range_id` -
+  (Optional)
+  Contains the name of allocated IP address ranges associated with
+  the private service access connection for example, "test-default"
+  associated with IP range 10.0.0.0/29.
+
 * `region` -
   (Optional)
   The region of the Memcache instance. If it is not provided, the provider region is used.