Skip to content

Commit 9f3cbac

Browse files
expand valid values for bigquery dataset (#7141) (#13520)
closes #13484 Signed-off-by: Modular Magician <[email protected]> Signed-off-by: Modular Magician <[email protected]>
1 parent b9f6caa commit 9f3cbac

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.changelog/7141.txt

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:bug
2+
bigquery: fixed bug where valid iam member values for bigquery were prevented from actuation by validation
3+
```

google/resource_iam_member.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func validateIAMMember(i interface{}, k string) ([]string, []error) {
3232
return nil, []error{fmt.Errorf("invalid value for %s (Terraform does not support IAM members for deleted principals)", k)}
3333
}
3434

35-
if matched, err := regexp.MatchString("(.+:.+|allUsers|allAuthenticatedUsers)", v); err != nil {
35+
if matched, err := regexp.MatchString("(.+:.+|projectOwners|projectReaders|projectWriters|allUsers|allAuthenticatedUsers)", v); err != nil {
3636
return nil, []error{fmt.Errorf("error validating %s: %v", k, err)}
3737
} else if !matched {
3838
return nil, []error{fmt.Errorf("invalid value for %s (IAM members must have one of the values outlined here: https://cloud.google.com/billing/docs/reference/rest/v1/Policy#Binding)", k)}

0 commit comments

Comments
 (0)