Permadiff fix: advertised_ip_ranges in cloud router (#11262) (#18869)

[upstream:2079ba534361934b883b1d56c162740cf3c2c895]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/11262.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+compute: fixed perma-diff in `google_compute_router`
+```

google/services/compute/resource_compute_router.go

@@ -646,7 +646,7 @@ func flattenComputeRouterBgpAdvertisedIpRanges(v interface{}, d *schema.Resource
 		})
 	}
 	configData := []map[string]interface{}{}
-	if v, ok := d.GetOk("advertised_ip_ranges"); ok {
+	if v, ok := d.GetOk("bgp.0.advertised_ip_ranges"); ok {
 		for _, item := range v.([]interface{}) {
 			configData = append(configData, item.(map[string]interface{}))
 		}

google/services/compute/resource_compute_router_test.go

@@ -79,6 +79,29 @@ func TestAccComputeRouter_full(t *testing.T) {
 	})
 }
 
+func TestAccComputeRouter_advertisedIpRangesOrder(t *testing.T) {
+	t.Parallel()
+
+	testId := acctest.RandString(t, 10)
+	routerName := fmt.Sprintf("tf-test-router-%s", testId)
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeRouterDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeRouterAdvertisedIpRangesOrder(routerName),
+			},
+			{
+				ResourceName:            "google_compute_router.foobar",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"bgp.0.advertised_ip_ranges.0.range", "bgp.0.advertised_ip_ranges.1.range"},
+			},
+		},
+	})
+}
+
 func TestAccComputeRouter_update(t *testing.T) {
 	t.Parallel()
 
@@ -265,6 +288,32 @@ resource "google_compute_router" "foobar" {
 `, routerName, routerName)
 }
 
+func testAccComputeRouterAdvertisedIpRangesOrder(routerName string) string {
+	return fmt.Sprintf(`
+resource "google_compute_network" "foobar" {
+  name                    = "%s-net"
+  auto_create_subnetworks = false
+}
+
+resource "google_compute_router" "foobar" {
+  name    = "%s"
+  network = google_compute_network.foobar.name
+  bgp {
+    asn               = 64514
+    advertise_mode    = "CUSTOM"
+    advertised_groups = ["ALL_SUBNETS"]
+	advertised_ip_ranges {
+      range = "6.7.0.0/16"
+    }
+    advertised_ip_ranges {
+      range = "1.2.3.4"
+    }
+    keepalive_interval = 25
+  }
+}
+`, routerName, routerName)
+}
+
 func testAccComputeRouter_noBGP(routerName, resourceRegion string) string {
 	return fmt.Sprintf(`
 resource "google_compute_network" "foobar" {