Skip to content

Commit b072474

Browse files
modular-magicianrileykarson
authored andcommitted
Add note that Cloud Build trigger_template is required. (#4452)
Signed-off-by: Modular Magician <[email protected]>
1 parent ef6394c commit b072474

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

google/resource_service_networking_connection.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -177,12 +177,11 @@ func resourceServiceNetworkingConnectionDelete(d *schema.ResourceData, meta inte
177177
obj["name"] = peering
178178
url := fmt.Sprintf("%s%s/removePeering", config.ComputeBasePath, serviceNetworkingNetworkName)
179179

180-
networkFieldValue, err := ParseNetworkFieldValue(network, d, config)
180+
project, err := getProject(d, config)
181181
if err != nil {
182-
return errwrap.Wrapf("Failed to retrieve network field value, err: {{err}}", err)
182+
return err
183183
}
184184

185-
project := networkFieldValue.Project
186185
res, err := sendRequestWithTimeout(config, "POST", project, url, obj, d.Timeout(schema.TimeoutUpdate))
187186
if err != nil {
188187
return handleNotFoundError(err, d, fmt.Sprintf("ServiceNetworkingConnection %q", d.Id()))

website/docs/r/cloudbuild_trigger.html.markdown

+2-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ The following arguments are supported:
106106
Template describing the types of source changes to trigger a build.
107107
Branch and tag names in trigger templates are interpreted as regular
108108
expressions. Any branch or tag change that matches that regular
109-
expression will trigger a build. Structure is documented below.
109+
expression will trigger a build.
110+
This field is required, and will be validated as such in 3.0.0. Structure is documented below.
110111

111112
* `build` -
112113
(Optional)

0 commit comments

Comments
 (0)