Add update support to reconcile_connections in service attachment (#8831) (#15706)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/8831.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: added update support for `reconcile_connections` in `google_compute_service_attachment`
+```

google/services/compute/resource_compute_service_attachment.go

@@ -139,7 +139,6 @@ supported is 1.`,
 			"reconcile_connections": {
 				Type:     schema.TypeBool,
 				Optional: true,
-				ForceNew: true,
 				Description: `This flag determines whether a consumer accept/reject list change can reconcile the statuses of existing ACCEPTED or REJECTED PSC endpoints.
 
 If false, connection policy update will only affect existing PENDING PSC endpoints. Existing ACCEPTED/REJECTED endpoints will remain untouched regardless how the connection policy is modified .
@@ -471,6 +470,12 @@ func resourceComputeServiceAttachmentUpdate(d *schema.ResourceData, meta interfa
 	} else if v, ok := d.GetOkExists("consumer_accept_lists"); ok || !reflect.DeepEqual(v, consumerAcceptListsProp) {
 		obj["consumerAcceptLists"] = consumerAcceptListsProp
 	}
+	reconcileConnectionsProp, err := expandComputeServiceAttachmentReconcileConnections(d.Get("reconcile_connections"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("reconcile_connections"); ok || !reflect.DeepEqual(v, reconcileConnectionsProp) {
+		obj["reconcileConnections"] = reconcileConnectionsProp
+	}
 
 	obj, err = resourceComputeServiceAttachmentUpdateEncoder(d, meta, obj)
 	if err != nil {

google/services/compute/resource_compute_service_attachment_test.go

@@ -144,6 +144,7 @@ resource "google_compute_service_attachment" "psc_ilb_service_attachment" {
     connection_limit  = 4
   }
 
+  reconcile_connections = false
 }
 
 resource "google_compute_address" "psc_ilb_consumer_address" {