Promote source_regions field in google_compute_healthcheck to ga (#11374) (#19006)

[upstream:9ec8aa084b6d66b7c8fb25f1e4fc3007714e1605]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/11374.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+compute: added `source_regions` field to `google_compute_healthcheck` resource (ga)
+```

google/services/compute/resource_compute_health_check.go

@@ -485,6 +485,32 @@ which means no health check logging will be done.`,
 					},
 				},
 			},
+			"source_regions": {
+				Type:     schema.TypeList,
+				Optional: true,
+				Description: `The list of cloud regions from which health checks are performed. If
+any regions are specified, then exactly 3 regions should be specified.
+The region names must be valid names of Google Cloud regions. This can
+only be set for global health check. If this list is non-empty, then
+there are restrictions on what other health check fields are supported
+and what other resources can use this health check:
+
+* SSL, HTTP2, and GRPC protocols are not supported.
+
+* The TCP request field is not supported.
+
+* The proxyHeader field for HTTP, HTTPS, and TCP is not supported.
+
+* The checkIntervalSec field must be at least 30.
+
+* The health check cannot be used with BackendService nor with managed
+instance group auto-healing.`,
+				MinItems: 3,
+				MaxItems: 3,
+				Elem: &schema.Schema{
+					Type: schema.TypeString,
+				},
+			},
 			"ssl_health_check": {
 				Type:             schema.TypeList,
 				Optional:         true,
@@ -707,6 +733,12 @@ func resourceComputeHealthCheckCreate(d *schema.ResourceData, meta interface{})
 	} else if v, ok := d.GetOkExists("timeout_sec"); !tpgresource.IsEmptyValue(reflect.ValueOf(timeoutSecProp)) && (ok || !reflect.DeepEqual(v, timeoutSecProp)) {
 		obj["timeoutSec"] = timeoutSecProp
 	}
+	sourceRegionsProp, err := expandComputeHealthCheckSourceRegions(d.Get("source_regions"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("source_regions"); !tpgresource.IsEmptyValue(reflect.ValueOf(sourceRegionsProp)) && (ok || !reflect.DeepEqual(v, sourceRegionsProp)) {
+		obj["sourceRegions"] = sourceRegionsProp
+	}
 	unhealthyThresholdProp, err := expandComputeHealthCheckUnhealthyThreshold(d.Get("unhealthy_threshold"), d, config)
 	if err != nil {
 		return err
@@ -877,6 +909,9 @@ func resourceComputeHealthCheckRead(d *schema.ResourceData, meta interface{}) er
 	if err := d.Set("timeout_sec", flattenComputeHealthCheckTimeoutSec(res["timeoutSec"], d, config)); err != nil {
 		return fmt.Errorf("Error reading HealthCheck: %s", err)
 	}
+	if err := d.Set("source_regions", flattenComputeHealthCheckSourceRegions(res["sourceRegions"], d, config)); err != nil {
+		return fmt.Errorf("Error reading HealthCheck: %s", err)
+	}
 	if err := d.Set("unhealthy_threshold", flattenComputeHealthCheckUnhealthyThreshold(res["unhealthyThreshold"], d, config)); err != nil {
 		return fmt.Errorf("Error reading HealthCheck: %s", err)
 	}
@@ -957,6 +992,12 @@ func resourceComputeHealthCheckUpdate(d *schema.ResourceData, meta interface{})
 	} else if v, ok := d.GetOkExists("timeout_sec"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, timeoutSecProp)) {
 		obj["timeoutSec"] = timeoutSecProp
 	}
+	sourceRegionsProp, err := expandComputeHealthCheckSourceRegions(d.Get("source_regions"), d, config)
+	if err != nil {
+		return err
+	} else if v, ok := d.GetOkExists("source_regions"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, sourceRegionsProp)) {
+		obj["sourceRegions"] = sourceRegionsProp
+	}
 	unhealthyThresholdProp, err := expandComputeHealthCheckUnhealthyThreshold(d.Get("unhealthy_threshold"), d, config)
 	if err != nil {
 		return err
@@ -1191,6 +1232,10 @@ func flattenComputeHealthCheckTimeoutSec(v interface{}, d *schema.ResourceData,
 	return v // let terraform core handle it otherwise
 }
 
+func flattenComputeHealthCheckSourceRegions(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
+	return v
+}
+
 func flattenComputeHealthCheckUnhealthyThreshold(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
 	// Handles the string fixed64 format
 	if strVal, ok := v.(string); ok {
@@ -1611,6 +1656,10 @@ func expandComputeHealthCheckTimeoutSec(v interface{}, d tpgresource.TerraformRe
 	return v, nil
 }
 
+func expandComputeHealthCheckSourceRegions(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
+	return v, nil
+}
+
 func expandComputeHealthCheckUnhealthyThreshold(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
 	return v, nil
 }

google/services/compute/resource_compute_health_check_test.go

@@ -338,3 +338,61 @@ resource "google_compute_health_check" "foobar" {
 }
 `, hckName)
 }
+
+func TestAccComputeHealthCheck_srcRegions_update(t *testing.T) {
+	t.Parallel()
+
+	hckName := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeHealthCheckDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputeHealthCheck_srcRegions(hckName),
+			},
+			{
+				ResourceName:      "google_compute_health_check.src_region",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+			{
+				Config: testAccComputeHealthCheck_srcRegions_update(hckName),
+			},
+			{
+				ResourceName:      "google_compute_health_check.src_region",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
+func testAccComputeHealthCheck_srcRegions(hckName string) string {
+	return fmt.Sprintf(`
+resource "google_compute_health_check" "src_region" {
+  name                = "%s"
+  description         = "Resource created for Terraform acceptance testing"
+  check_interval_sec  = 30
+  source_regions      = ["us-central1", "us-east1", "asia-south1"]
+  http_health_check {
+    port          = "80"
+  }
+}
+`, hckName)
+}
+
+func testAccComputeHealthCheck_srcRegions_update(hckName string) string {
+	return fmt.Sprintf(`
+resource "google_compute_health_check" "src_region" {
+  name                = "%s"
+  description         = "Resource updated for Terraform acceptance testing"
+  check_interval_sec  = 30
+  source_regions      = ["us-west1", "europe-north1", "asia-south1"]
+  http_health_check {
+    port          = "80"
+  }
+}
+`, hckName)
+}

website/docs/r/compute_health_check.html.markdown

@@ -390,7 +390,7 @@ The following arguments are supported:
   greater value than checkIntervalSec.
 
 * `source_regions` -
-  (Optional, [Beta](https://terraform.io/docs/providers/google/guides/provider_versions.html))
+  (Optional)
   The list of cloud regions from which health checks are performed. If
   any regions are specified, then exactly 3 regions should be specified.
   The region names must be valid names of Google Cloud regions. This can