Skip to content

Commit c356ff7

Browse files
update certificate example to use generated key (#8451) (#15332)
Signed-off-by: Modular Magician <[email protected]>
1 parent 6bd1fb8 commit c356ff7

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

.changelog/8451.txt

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note: none
2+
3+
```

google/resource_privateca_certificate_generated_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ func TestAccPrivatecaCertificate_privatecaCertificateConfigExample(t *testing.T)
5959

6060
func testAccPrivatecaCertificate_privatecaCertificateConfigExample(context map[string]interface{}) string {
6161
return acctest.Nprintf(`
62+
6263
resource "google_privateca_ca_pool" "default" {
6364
location = "us-central1"
6465
name = "tf-test-my-pool%{random_suffix}"

website/docs/r/privateca_certificate.html.markdown

+10-6
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ A Certificate corresponds to a signed X.509 certificate issued by a Certificate.
2727

2828

2929

30-
## Example Usage - Privateca Certificate Config
30+
## Example Usage - Privateca Certificate Generated Key
3131

3232

3333
```hcl
3434
resource "google_privateca_ca_pool" "default" {
3535
location = "us-central1"
36-
name = "my-pool"
36+
name = "default"
3737
tier = "ENTERPRISE"
3838
}
3939
@@ -76,12 +76,16 @@ resource "google_privateca_certificate_authority" "default" {
7676
ignore_active_certificates_on_deletion = true
7777
}
7878
79+
resource "tls_private_key" "cert_key" {
80+
algorithm = "RSA"
81+
}
82+
7983
resource "google_privateca_certificate" "default" {
8084
location = "us-central1"
8185
pool = google_privateca_ca_pool.default.name
8286
certificate_authority = google_privateca_certificate_authority.default.certificate_authority_id
8387
lifetime = "86000s"
84-
name = "my-certificate"
88+
name = "cert-1"
8589
config {
8690
subject_config {
8791
subject {
@@ -105,8 +109,8 @@ resource "google_privateca_certificate" "default" {
105109
}
106110
key_usage {
107111
base_key_usage {
108-
crl_sign = false
109-
decipher_only = false
112+
cert_sign = true
113+
crl_sign = true
110114
}
111115
extended_key_usage {
112116
server_auth = false
@@ -126,7 +130,7 @@ resource "google_privateca_certificate" "default" {
126130
}
127131
public_key {
128132
format = "PEM"
129-
key = filebase64("test-fixtures/rsa_public.pem")
133+
key = base64encode(tls_private_key.cert_key.public_key_pem)
130134
}
131135
}
132136
}

0 commit comments

Comments
 (0)