fix: permadiff issue when docker_repository field is not specified (#9850) (#17072)

modular-magician · web-flow · commit cc2ea534469e · 2024-01-22T14:24:20.000-08:00
relates to GoogleCloudPlatform/cloud-foundation-fabric#1987 When docker repository is not specified by default docker repository`projects/PROJECT_ID/locations/REGION/repositories/gcf-artifacts` is used.In such a case, terraform plan always generates a difference for `docker_repository`field as the module passes null value but the tfstate file has the above specifieddefault value. This fix allows one to prevent unnecessary infrastructure change. [upstream:3540e663502c1286967dd61650bb8ee7c2b35cf9] Signed-off-by: Modular Magician <magic-modules@google.com>
diff --git a/.changelog/9850.txt b/.changelog/9850.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+Fixed an issue when `docker_repository` is not specified in build_config section of the `google_cloudfunctions2_function`, the provider should not generate a diff during plan for the default value used by the API.
+```
diff --git a/google/services/cloudfunctions2/resource_cloudfunctions2_function.go b/google/services/cloudfunctions2/resource_cloudfunctions2_function.go
@@ -78,6 +78,7 @@ from the given source.`,
 					Schema: map[string]*schema.Schema{
 						"docker_repository": {
 							Type:        schema.TypeString,
+							Computed:    true,
 							Optional:    true,
 							Description: `User managed repository created in Artifact Registry optionally with a customer managed encryption key.`,
 						},

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+```release-note:bug
	`2`	+Fixed an issue when `docker_repository` is not specified in build_config section of the `google_cloudfunctions2_function`, the provider should not generate a diff during plan for the default value used by the API.
	`3`	+```