Prevent infinite loop in TestAccComputeDisk_imageDiffSuppressPublicVe… (#9273) (#16266)

[upstream:92f92bf55c85dc529bc38d4600e963cef0077cd1]

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/9273.txt

@@ -0,0 +1,3 @@
+```release-note:none
+
+```

google/services/compute/resource_compute_disk_test.go

@@ -307,7 +307,11 @@ func TestAccComputeDisk_imageDiffSuppressPublicVendorsFamilyNames(t *testing.T)
 
 	for _, publicImageProject := range tpgcompute.ImageMap {
 		token := ""
-		for paginate := true; paginate; {
+		// Hard limit on number of pages to prevent infinite loops
+		// caused by the API always returning a pagination token
+		page := 0
+		maxPages := 10
+		for paginate := true; paginate && page < maxPages; {
 			resp, err := config.NewComputeClient(config.UserAgent).Images.List(publicImageProject).Filter("deprecated.replacement ne .*images.*").PageToken(token).Do()
 			if err != nil {
 				t.Fatalf("Can't list public images for project %q", publicImageProject)
@@ -320,6 +324,7 @@ func TestAccComputeDisk_imageDiffSuppressPublicVendorsFamilyNames(t *testing.T)
 			}
 			token := resp.NextPageToken
 			paginate = token != ""
+			page++
 		}
 	}
 }