Add website doc for resource storage_bucket_iam_policy

Author: Sébastien GLON

google/resource_container_cluster.go

@@ -225,16 +225,17 @@ func resourceContainerCluster() *schema.Resource {
 								},
 							},
 						},
-						"dashboard": {
+						"kubernetes_dashboard": {
 							Type:     schema.TypeList,
-							Optional: false,
+							Optional: true,
+							ForceNew: true,
 							MaxItems: 1,
 							Elem: &schema.Resource{
 								Schema: map[string]*schema.Schema{
 									"disabled": {
 										Type:     schema.TypeBool,
 										Optional: true,
-										ForceNew: false,
+										ForceNew: true,
 									},
 								},
 							},
@@ -386,7 +387,8 @@ func resourceContainerClusterCreate(d *schema.ResourceData, meta interface{}) er
 				Disabled: addon["disabled"].(bool),
 			}
 		}
-		if v, ok := addonsConfig["dashboard"]; ok && len(v.([]interface{})) > 0 {
+
+		if v, ok := addonsConfig["kubernetes_dashboard"]; ok && len(v.([]interface{})) > 0 {
 			addon := v.([]interface{})[0].(map[string]interface{})
 			cluster.AddonsConfig.KubernetesDashboard = &container.KubernetesDashboard{
 				Disabled: addon["disabled"].(bool),

google/resource_container_cluster_test.go

@@ -558,17 +558,18 @@ func testAccCheckContainerCluster(n string) resource.TestCheckFunc {
 		}
 		clusterTests = append(clusterTests, clusterTestField{"additional_zones", additionalZones})
 
-		// AddonsConfig is neither Required or Computed, so the API may return nil for it
-		if cluster.AddonsConfig != nil {
-			if cluster.AddonsConfig.HttpLoadBalancing != nil {
-				clusterTests = append(clusterTests, clusterTestField{"addons_config.0.http_load_balancing.0.disabled", strconv.FormatBool(cluster.AddonsConfig.HttpLoadBalancing.Disabled)})
-			}
-			if cluster.AddonsConfig.HorizontalPodAutoscaling != nil {
-				clusterTests = append(clusterTests, clusterTestField{"addons_config.0.horizontal_pod_autoscaling.0.disabled", strconv.FormatBool(cluster.AddonsConfig.HorizontalPodAutoscaling.Disabled)})
-			}
-			if cluster.AddonsConfig.KubernetesDashboard != nil {
-				clusterTests = append(clusterTests, clusterTestField{"addons_config.0.KubernetesDashboard.0.disabled", strconv.FormatBool(cluster.AddonsConfig.KubernetesDashboard.Disabled)})
-			}
+		// AddonsConfig is neither Required or Computed, so the API may return nil for it.
+		httpLoadBalancingDisabled := false
+		if cluster.AddonsConfig != nil && cluster.AddonsConfig.HttpLoadBalancing != nil {
+			httpLoadBalancingDisabled = cluster.AddonsConfig.HttpLoadBalancing.Disabled
+		}
+		horizontalPodAutoscalingDisabled := false
+		if cluster.AddonsConfig != nil && cluster.AddonsConfig.HorizontalPodAutoscaling != nil {
+			horizontalPodAutoscalingDisabled = cluster.AddonsConfig.HorizontalPodAutoscaling.Disabled
+		}
+		kubernetesDashboardDisabled := false
+		if cluster.AddonsConfig != nil && cluster.AddonsConfig.KubernetesDashboard != nil {
+			kubernetesDashboardDisabled = cluster.AddonsConfig.KubernetesDashboard.Disabled
 		}
 		clusterTests = append(clusterTests, clusterTestField{"addons_config.0.http_load_balancing.0.disabled", httpLoadBalancingDisabled})
 		clusterTests = append(clusterTests, clusterTestField{"addons_config.0.horizontal_pod_autoscaling.0.disabled", horizontalPodAutoscalingDisabled})

google/resource_storage_bucket.go

@@ -534,7 +534,7 @@ func resourceGCSBucketLifecycleCreateOrUpdate(d *schema.ResourceData, sb *storag
 					}
 
 					if v, ok := condition["is_live"]; ok {
-						target_lifecycle_rule.Condition.IsLive = v.(*bool)
+						target_lifecycle_rule.Condition.IsLive = v.(bool)
 					}
 
 					if v, ok := condition["matches_storage_class"]; ok {