Skip to content

Commit e4f1e32

Browse files
Add disable_bundled_ingress in google_gkeonprem_vmware_cluster (#10310) (#17718)
[upstream:bd42e573fb11c414fe217f3cc35e891b77490faa] Signed-off-by: Modular Magician <[email protected]>
1 parent 9e82c2d commit e4f1e32

5 files changed

+43
-0
lines changed

.changelog/10310.txt

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
```release-note:enhancement
2+
gkeonprem: added `disable_bundled_ingress` field to `google_gkeonprem_vmware_cluster` resource
3+
```

google/services/gkeonprem/resource_gkeonprem_vmware_cluster.go

+32
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,11 @@ full access to the cluster.`,
255255
Optional: true,
256256
Description: `A human readable description of this VMware User Cluster.`,
257257
},
258+
"disable_bundled_ingress": {
259+
Type: schema.TypeBool,
260+
Optional: true,
261+
Description: `Disable bundled ingress.`,
262+
},
258263
"enable_control_plane_v2": {
259264
Type: schema.TypeBool,
260265
Optional: true,
@@ -980,6 +985,12 @@ func resourceGkeonpremVmwareClusterCreate(d *schema.ResourceData, meta interface
980985
} else if v, ok := d.GetOkExists("enable_control_plane_v2"); !tpgresource.IsEmptyValue(reflect.ValueOf(enableControlPlaneV2Prop)) && (ok || !reflect.DeepEqual(v, enableControlPlaneV2Prop)) {
981986
obj["enableControlPlaneV2"] = enableControlPlaneV2Prop
982987
}
988+
disableBundledIngressProp, err := expandGkeonpremVmwareClusterDisableBundledIngress(d.Get("disable_bundled_ingress"), d, config)
989+
if err != nil {
990+
return err
991+
} else if v, ok := d.GetOkExists("disable_bundled_ingress"); !tpgresource.IsEmptyValue(reflect.ValueOf(disableBundledIngressProp)) && (ok || !reflect.DeepEqual(v, disableBundledIngressProp)) {
992+
obj["disableBundledIngress"] = disableBundledIngressProp
993+
}
983994
upgradePolicyProp, err := expandGkeonpremVmwareClusterUpgradePolicy(d.Get("upgrade_policy"), d, config)
984995
if err != nil {
985996
return err
@@ -1145,6 +1156,9 @@ func resourceGkeonpremVmwareClusterRead(d *schema.ResourceData, meta interface{}
11451156
if err := d.Set("enable_control_plane_v2", flattenGkeonpremVmwareClusterEnableControlPlaneV2(res["enableControlPlaneV2"], d, config)); err != nil {
11461157
return fmt.Errorf("Error reading VmwareCluster: %s", err)
11471158
}
1159+
if err := d.Set("disable_bundled_ingress", flattenGkeonpremVmwareClusterDisableBundledIngress(res["disableBundledIngress"], d, config)); err != nil {
1160+
return fmt.Errorf("Error reading VmwareCluster: %s", err)
1161+
}
11481162
if err := d.Set("upgrade_policy", flattenGkeonpremVmwareClusterUpgradePolicy(res["upgradePolicy"], d, config)); err != nil {
11491163
return fmt.Errorf("Error reading VmwareCluster: %s", err)
11501164
}
@@ -1279,6 +1293,12 @@ func resourceGkeonpremVmwareClusterUpdate(d *schema.ResourceData, meta interface
12791293
} else if v, ok := d.GetOkExists("enable_control_plane_v2"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, enableControlPlaneV2Prop)) {
12801294
obj["enableControlPlaneV2"] = enableControlPlaneV2Prop
12811295
}
1296+
disableBundledIngressProp, err := expandGkeonpremVmwareClusterDisableBundledIngress(d.Get("disable_bundled_ingress"), d, config)
1297+
if err != nil {
1298+
return err
1299+
} else if v, ok := d.GetOkExists("disable_bundled_ingress"); !tpgresource.IsEmptyValue(reflect.ValueOf(v)) && (ok || !reflect.DeepEqual(v, disableBundledIngressProp)) {
1300+
obj["disableBundledIngress"] = disableBundledIngressProp
1301+
}
12821302
upgradePolicyProp, err := expandGkeonpremVmwareClusterUpgradePolicy(d.Get("upgrade_policy"), d, config)
12831303
if err != nil {
12841304
return err
@@ -1354,6 +1374,10 @@ func resourceGkeonpremVmwareClusterUpdate(d *schema.ResourceData, meta interface
13541374
updateMask = append(updateMask, "enableControlPlaneV2")
13551375
}
13561376

1377+
if d.HasChange("disable_bundled_ingress") {
1378+
updateMask = append(updateMask, "disableBundledIngress")
1379+
}
1380+
13571381
if d.HasChange("upgrade_policy") {
13581382
updateMask = append(updateMask, "upgradePolicy")
13591383
}
@@ -2246,6 +2270,10 @@ func flattenGkeonpremVmwareClusterEnableControlPlaneV2(v interface{}, d *schema.
22462270
return v
22472271
}
22482272

2273+
func flattenGkeonpremVmwareClusterDisableBundledIngress(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
2274+
return v
2275+
}
2276+
22492277
func flattenGkeonpremVmwareClusterUpgradePolicy(v interface{}, d *schema.ResourceData, config *transport_tpg.Config) interface{} {
22502278
if v == nil {
22512279
return nil
@@ -3326,6 +3354,10 @@ func expandGkeonpremVmwareClusterEnableControlPlaneV2(v interface{}, d tpgresour
33263354
return v, nil
33273355
}
33283356

3357+
func expandGkeonpremVmwareClusterDisableBundledIngress(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
3358+
return v, nil
3359+
}
3360+
33293361
func expandGkeonpremVmwareClusterUpgradePolicy(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) {
33303362
l := v.([]interface{})
33313363
if len(l) == 0 || l[0] == nil {

google/services/gkeonprem/resource_gkeonprem_vmware_cluster_generated_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ resource "google_gkeonprem_vmware_cluster" "cluster-f5lb" {
178178
}
179179
vm_tracking_enabled = true
180180
enable_control_plane_v2 = true
181+
disable_bundled_ingress = true
181182
authorization {
182183
admin_users {
183184
username = "[email protected]"

google/services/gkeonprem/resource_gkeonprem_vmware_cluster_test.go

+2
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,7 @@ func testAccGkeonpremVmwareCluster_vmwareClusterUpdateManualLbStart(context map[
373373
}
374374
vm_tracking_enabled = true
375375
enable_control_plane_v2 = true
376+
disable_bundled_ingress = true
376377
upgrade_policy {
377378
control_plane_only = true
378379
}
@@ -465,6 +466,7 @@ func testAccGkeonpremVmwareCluster_vmwareClusterUpdateManualLb(context map[strin
465466
}
466467
vm_tracking_enabled = false
467468
enable_control_plane_v2 = false
469+
disable_bundled_ingress = false
468470
upgrade_policy {
469471
control_plane_only = true
470472
}

website/docs/r/gkeonprem_vmware_cluster.html.markdown

+5
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ resource "google_gkeonprem_vmware_cluster" "cluster-f5lb" {
123123
}
124124
vm_tracking_enabled = true
125125
enable_control_plane_v2 = true
126+
disable_bundled_ingress = true
126127
authorization {
127128
admin_users {
128129
username = "[email protected]"
@@ -374,6 +375,10 @@ The following arguments are supported:
374375
(Optional)
375376
Enable control plane V2. Default to false.
376377

378+
* `disable_bundled_ingress` -
379+
(Optional)
380+
Disable bundled ingress.
381+
377382
* `upgrade_policy` -
378383
(Optional)
379384
Specifies upgrade policy for the cluster.

0 commit comments

Comments
 (0)