Make google_monitoring_metric_descriptor.labels ForceNew (#8914) (#15988)

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/8914.txt

@@ -0,0 +1,6 @@
+```release-note:breaking-change
+monitoring: made `labels` immutable in `google_monitoring_metric_descriptor`
+```
+```release-note:bug
+monitoring: fixed an issue where `metadata` was not able to be updated in `google_monitoring_metric_descriptor`
+```

google/services/monitoring/resource_monitoring_metric_descriptor.go

@@ -88,6 +88,7 @@ func ResourceMonitoringMetricDescriptor() *schema.Resource {
 			"labels": {
 				Type:        schema.TypeSet,
 				Optional:    true,
+				ForceNew:    true,
 				Description: `The set of labels that can be used to describe a specific instance of this metric type. In order to delete a label, the entire resource must be deleted, then created with the desired labels.`,
 				Elem:        monitoringMetricDescriptorLabelsSchema(),
 				// Default schema.HashSchema is used.
@@ -102,7 +103,6 @@ func ResourceMonitoringMetricDescriptor() *schema.Resource {
 			"metadata": {
 				Type:        schema.TypeList,
 				Optional:    true,
-				ForceNew:    true,
 				Description: `Metadata which can be used to guide usage of the metric.`,
 				MaxItems:    1,
 				Elem: &schema.Resource{

google/services/monitoring/resource_monitoring_metric_descriptor_test.go

@@ -11,8 +11,6 @@ import (
 )
 
 func TestAccMonitoringMetricDescriptor_update(t *testing.T) {
-	// TODO: Fix requires a breaking change https://github.com/hashicorp/terraform-provider-google/issues/12139
-	t.Skip()
 
 	t.Parallel()
 	acctest.VcrTest(t, resource.TestCase{
@@ -21,8 +19,7 @@ func TestAccMonitoringMetricDescriptor_update(t *testing.T) {
 		CheckDestroy:             testAccCheckMonitoringMetricDescriptorDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccMonitoringMetricDescriptor_update("key1", "STRING",
-					"description1", "30s", "30s"),
+				Config: testAccMonitoringMetricDescriptor_update("30s", "30s"),
 			},
 			{
 				ResourceName:            "google_monitoring_metric_descriptor.basic",
@@ -31,8 +28,7 @@ func TestAccMonitoringMetricDescriptor_update(t *testing.T) {
 				ImportStateVerifyIgnore: []string{"metadata", "launch_stage"},
 			},
 			{
-				Config: testAccMonitoringMetricDescriptor_update("key2", "INT64",
-					"description2", "60s", "60s"),
+				Config: testAccMonitoringMetricDescriptor_update("60s", "60s"),
 			},
 			{
 				ResourceName:            "google_monitoring_metric_descriptor.basic",
@@ -44,8 +40,7 @@ func TestAccMonitoringMetricDescriptor_update(t *testing.T) {
 	})
 }
 
-func testAccMonitoringMetricDescriptor_update(key, valueType, description,
-	samplePeriod, ingestDelay string) string {
+func testAccMonitoringMetricDescriptor_update(samplePeriod, ingestDelay string) string {
 	return fmt.Sprintf(`
 resource "google_monitoring_metric_descriptor" "basic" {
 	description = "Daily sales records from all branch stores."
@@ -55,16 +50,16 @@ resource "google_monitoring_metric_descriptor" "basic" {
 	value_type = "DOUBLE"
 	unit = "{USD}"
 	labels {
-		key = "%s"
-		value_type = "%s"
-		description = "%s"
+		key = "key"
+		value_type = "STRING"
+		description = "description"
 	}
 	launch_stage = "BETA"
 	metadata {
 		sample_period = "%s"
 		ingest_delay = "%s"
 	}
 }
-`, key, valueType, description, samplePeriod, ingestDelay,
+`, samplePeriod, ingestDelay,
 	)
 }