Add force delete for notifiaction channel (#6474) (#12414)

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>

Author: modular-magician

.changelog/6474.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+monitoring: added `force_delete` field to `google_monitoring_notification_channel` resource
+```

google/resource_monitoring_notification_channel.go

@@ -145,6 +145,11 @@ The [CHANNEL_ID] is automatically assigned by the server on creation.`,
 				Computed:    true,
 				Description: `Indicates whether this channel has been verified or not. On a ListNotificationChannels or GetNotificationChannel operation, this field is expected to be populated.If the value is UNVERIFIED, then it indicates that the channel is non-functioning (it both requires verification and lacks verification); otherwise, it is assumed that the channel works.If the channel is neither VERIFIED nor UNVERIFIED, it implies that the channel is of a type that does not require verification or that this specific channel has been exempted from verification because it was created prior to verification being required for channels of this type.This field cannot be modified using a standard UpdateNotificationChannel operation. To change the value of this field, you must call VerifyNotificationChannel.`,
 			},
+			"force_delete": {
+				Type:     schema.TypeBool,
+				Optional: true,
+				Default:  false,
+			},
 			"project": {
 				Type:     schema.TypeString,
 				Optional: true,
@@ -312,6 +317,12 @@ func resourceMonitoringNotificationChannelRead(d *schema.ResourceData, meta inte
 		return nil
 	}
 
+	// Explicitly set virtual fields to default values if unset
+	if _, ok := d.GetOkExists("force_delete"); !ok {
+		if err := d.Set("force_delete", false); err != nil {
+			return fmt.Errorf("Error setting force_delete: %s", err)
+		}
+	}
 	if err := d.Set("project", project); err != nil {
 		return fmt.Errorf("Error reading NotificationChannel: %s", err)
 	}
@@ -454,7 +465,7 @@ func resourceMonitoringNotificationChannelDelete(d *schema.ResourceData, meta in
 	mutexKV.Lock(lockName)
 	defer mutexKV.Unlock(lockName)
 
-	url, err := replaceVars(d, config, "{{MonitoringBasePath}}v3/{{name}}")
+	url, err := replaceVars(d, config, "{{MonitoringBasePath}}v3/{{name}}?force={{force_delete}}")
 	if err != nil {
 		return err
 	}

google/resource_monitoring_notification_channel_generated_test.go

@@ -56,6 +56,7 @@ resource "google_monitoring_notification_channel" "basic" {
   labels = {
     email_address = "[email protected]"
   }
+  force_delete = false
 }
 `, context)
 }

google/resource_monitoring_notification_channel_sweeper_test.go

@@ -99,7 +99,7 @@ func testSweepMonitoringNotificationChannel(region string) error {
 			continue
 		}
 
-		deleteTemplate := "https://monitoring.googleapis.com/v3/{{name}}"
+		deleteTemplate := "https://monitoring.googleapis.com/v3/{{name}}?force={{force_delete}}"
 		deleteUrl, err := replaceVars(d, config, deleteTemplate)
 		if err != nil {
 			log.Printf("[INFO][SWEEPER_LOG] error preparing delete url: %s", err)

website/docs/r/monitoring_notification_channel.html.markdown

@@ -64,6 +64,7 @@ resource "google_monitoring_notification_channel" "basic" {
   labels = {
     email_address = "[email protected]"
   }
+  force_delete = false
 }
 ```
 ## Example Usage - Notification Channel Sensitive
@@ -133,6 +134,12 @@ The following arguments are supported:
 * `project` - (Optional) The ID of the project in which the resource belongs.
     If it is not provided, the provider project is used.
 
+* `force_delete` - (Optional) If true, the notification channel will be deleted regardless
+of its use in alert policies (the policies will be updated
+to remove the channel). If false, channels that are still
+referenced by an existing alerting policy will fail to be
+deleted in a delete operation.
+
 
 <a name="nested_sensitive_labels"></a>The `sensitive_labels` block supports: