Make "save_findings" Block Optional in Cloud DLP Configuration

[fribeiro1]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.2.2
on linux_amd64

• provider registry.terraform.io/hashicorp/google v4.24.0

Affected Resource(s)

• google_data_loss_prevention_job_trigger

Terraform Configuration Files

resource "google_data_loss_prevention_job_trigger" "samplejobtrigger" {
  parent = "projects/sampleproject"
  ...
  inspect_job {
    actions {
      save_findings {
        ...
      } # required
    }
    ...
  }
}

Debug Output

N/A.

Panic Output

N/A.

Expected Behavior

The "save_findings" block should be optional. It is optional in the API.

Actual Behavior

The "save_findings" block is required.

Steps to Reproduce

N/A.

Important Factoids

N/A.

References

• https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/data_loss_prevention_job_trigger
• https://cloud.google.com/dlp/docs/reference/rest/v2/Action

[melinath]

This is now optional:

terraform-provider-google/google/resource_data_loss_prevention_job_trigger.go

Line 141 in f323a73

"save_findings": {

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.