Skip to content

Reuse the same GOOGLE_FOLDER for our data source acceptance tests. #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rosbo opened this issue Apr 4, 2018 · 2 comments
Closed

Reuse the same GOOGLE_FOLDER for our data source acceptance tests. #1295

rosbo opened this issue Apr 4, 2018 · 2 comments

Comments

@rosbo
Copy link
Contributor

rosbo commented Apr 4, 2018

To avoid creating/deleting a bunch of folders, our tests for the google_folder and the google_active_folder datasource should reuse the same folder.

@rileykarson
Copy link
Collaborator

While it's not ideal that we create/destroy a lot of folders, unless it becomes an issue for some reason I'm inclined to say we don't need to bother with doing this. Closing out- if anyone sees this and feels strongly that we should do this, feel free to reopen/refile.

@ghost
Copy link

ghost commented Mar 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants