Skip to content

Commit aae57cd

Browse files
authored
Merge pull request #1214 from hathach/fix-gamepad-comment
correct 32 button in gamepad hid descriptor template
2 parents 44b131e + ab223eb commit aae57cd

File tree

1 file changed

+32
-32
lines changed

1 file changed

+32
-32
lines changed

src/class/hid/hid_device.h

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -310,46 +310,46 @@ static inline bool tud_hid_gamepad_report(uint8_t report_id, int8_t x, int8_t y
310310
HID_COLLECTION_END \
311311

312312
// Gamepad Report Descriptor Template
313-
// with 16 buttons, 2 joysticks and 1 hat/dpad with following layout
314-
// | X | Y | Z | Rz | Rx | Ry (1 byte each) | hat/DPAD (1 byte) | Button Map (2 bytes) |
313+
// with 32 buttons, 2 joysticks and 1 hat/dpad with following layout
314+
// | X | Y | Z | Rz | Rx | Ry (1 byte each) | hat/DPAD (1 byte) | Button Map (4 bytes) |
315315
#define TUD_HID_REPORT_DESC_GAMEPAD(...) \
316316
HID_USAGE_PAGE ( HID_USAGE_PAGE_DESKTOP ) ,\
317317
HID_USAGE ( HID_USAGE_DESKTOP_GAMEPAD ) ,\
318318
HID_COLLECTION ( HID_COLLECTION_APPLICATION ) ,\
319319
/* Report ID if any */\
320320
__VA_ARGS__ \
321321
/* 8 bit X, Y, Z, Rz, Rx, Ry (min -127, max 127 ) */ \
322-
HID_USAGE_PAGE ( HID_USAGE_PAGE_DESKTOP ) ,\
323-
HID_USAGE ( HID_USAGE_DESKTOP_X ) ,\
324-
HID_USAGE ( HID_USAGE_DESKTOP_Y ) ,\
325-
HID_USAGE ( HID_USAGE_DESKTOP_Z ) ,\
326-
HID_USAGE ( HID_USAGE_DESKTOP_RZ ) ,\
327-
HID_USAGE ( HID_USAGE_DESKTOP_RX ) ,\
328-
HID_USAGE ( HID_USAGE_DESKTOP_RY ) ,\
329-
HID_LOGICAL_MIN ( 0x81 ) ,\
330-
HID_LOGICAL_MAX ( 0x7f ) ,\
331-
HID_REPORT_COUNT ( 6 ) ,\
332-
HID_REPORT_SIZE ( 8 ) ,\
333-
HID_INPUT ( HID_DATA | HID_VARIABLE | HID_ABSOLUTE ) ,\
322+
HID_USAGE_PAGE ( HID_USAGE_PAGE_DESKTOP ) ,\
323+
HID_USAGE ( HID_USAGE_DESKTOP_X ) ,\
324+
HID_USAGE ( HID_USAGE_DESKTOP_Y ) ,\
325+
HID_USAGE ( HID_USAGE_DESKTOP_Z ) ,\
326+
HID_USAGE ( HID_USAGE_DESKTOP_RZ ) ,\
327+
HID_USAGE ( HID_USAGE_DESKTOP_RX ) ,\
328+
HID_USAGE ( HID_USAGE_DESKTOP_RY ) ,\
329+
HID_LOGICAL_MIN ( 0x81 ) ,\
330+
HID_LOGICAL_MAX ( 0x7f ) ,\
331+
HID_REPORT_COUNT ( 6 ) ,\
332+
HID_REPORT_SIZE ( 8 ) ,\
333+
HID_INPUT ( HID_DATA | HID_VARIABLE | HID_ABSOLUTE ) ,\
334334
/* 8 bit DPad/Hat Button Map */ \
335-
HID_USAGE_PAGE ( HID_USAGE_PAGE_DESKTOP ) ,\
336-
HID_USAGE ( HID_USAGE_DESKTOP_HAT_SWITCH ) ,\
337-
HID_LOGICAL_MIN ( 1 ) ,\
338-
HID_LOGICAL_MAX ( 8 ) ,\
339-
HID_PHYSICAL_MIN ( 0 ) ,\
340-
HID_PHYSICAL_MAX_N ( 315, 2 ) ,\
341-
HID_REPORT_COUNT ( 1 ) ,\
342-
HID_REPORT_SIZE ( 8 ) ,\
343-
HID_INPUT ( HID_DATA | HID_VARIABLE | HID_ABSOLUTE ) ,\
344-
/* 16 bit Button Map */ \
345-
HID_USAGE_PAGE ( HID_USAGE_PAGE_BUTTON ) ,\
346-
HID_USAGE_MIN ( 1 ) ,\
347-
HID_USAGE_MAX ( 32 ) ,\
348-
HID_LOGICAL_MIN ( 0 ) ,\
349-
HID_LOGICAL_MAX ( 1 ) ,\
350-
HID_REPORT_COUNT ( 32 ) ,\
351-
HID_REPORT_SIZE ( 1 ) ,\
352-
HID_INPUT ( HID_DATA | HID_VARIABLE | HID_ABSOLUTE ) ,\
335+
HID_USAGE_PAGE ( HID_USAGE_PAGE_DESKTOP ) ,\
336+
HID_USAGE ( HID_USAGE_DESKTOP_HAT_SWITCH ) ,\
337+
HID_LOGICAL_MIN ( 1 ) ,\
338+
HID_LOGICAL_MAX ( 8 ) ,\
339+
HID_PHYSICAL_MIN ( 0 ) ,\
340+
HID_PHYSICAL_MAX_N ( 315, 2 ) ,\
341+
HID_REPORT_COUNT ( 1 ) ,\
342+
HID_REPORT_SIZE ( 8 ) ,\
343+
HID_INPUT ( HID_DATA | HID_VARIABLE | HID_ABSOLUTE ) ,\
344+
/* 32 bit Button Map */ \
345+
HID_USAGE_PAGE ( HID_USAGE_PAGE_BUTTON ) ,\
346+
HID_USAGE_MIN ( 1 ) ,\
347+
HID_USAGE_MAX ( 32 ) ,\
348+
HID_LOGICAL_MIN ( 0 ) ,\
349+
HID_LOGICAL_MAX ( 1 ) ,\
350+
HID_REPORT_COUNT ( 32 ) ,\
351+
HID_REPORT_SIZE ( 1 ) ,\
352+
HID_INPUT ( HID_DATA | HID_VARIABLE | HID_ABSOLUTE ) ,\
353353
HID_COLLECTION_END \
354354

355355
// HID Generic Input & Output

0 commit comments

Comments
 (0)