fix: escape spaces in path completion #13388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo-main
force-pushed
the
fix-path-completion
branch
2 times, most recently
from
8a1f23e to
ffad5fb
Compare
yo-main
force-pushed
the
fix-path-completion
branch
from
ffad5fb to
8a33f78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13371
The flows for completion approximately goes like
path_completion->compile_path_regex->path_componentThe
path_componentregex expects spaces to be escaped, however thepath_completionfunction provides unescaped spaces.The PR tries to fix the original issue by correctly escaping spaces in path (and attempt to do it only in path). I'm not sure if that is the best way to go, happy to collect feedback on this !