Skip to content

Linux/(Gnome?) File dialogs don't show an error if Zenity isn't installed #20276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 5 tasks
quirkylemon opened this issue Apr 19, 2025 · 2 comments
Open
2 of 5 tasks

Comments

@quirkylemon
Copy link
Contributor

quirkylemon commented Apr 19, 2025

Game or games this happens in

None

What area of the game / PPSSPP

I'm using the latest commit on Fedora 41 Gnome
From what I've tested, if Zenity isn't installed, file dialogs don't show up or throw an error.
Everything works properly if Zenity is installed.
I haven't tested the QT version.

For example, the "Load..." button on the main menu does nothing.
The same issue applies to all of the load/save symbol buttons in the ImDebugger

What should happen

File dialogs should either display an error whenever Zenity isn't installed, or we should find a solution for file dialogs that doesn't require Zenity, eg modifying portable-file-dialogs or switching to a different library.

Whenever we decide what to do, I would be happy to fix it.

Logs

No response

Platform

Linux / BSD

Mobile device model or graphics card (GPU)

AMD Radeon Graphics (radeonsi, renoir, ACO, DRM 3.61, 6.13.9-200.fc41.x86_64)

PPSSPP version affected

v1.18.1-1767-g5b9f416afc

Last working version

No response

Graphics backend (3D API)

OpenGL / GLES

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try without any cheats and without loading any save states.
  • Include logs or screenshots of issue.
@hrydgard
Copy link
Owner

hrydgard commented Apr 20, 2025

We actually already ask pfd if a file dialog is available, and we only show these buttons if it is:

return pfd::settings::available();

So it seems there's a bug in portable-file-dialog.

Could you point me to some file dialog library that would work on your system?

It's really annoying on Linux that there's no standard way to just pop a file dialog.

@quirkylemon
Copy link
Contributor Author

Ok, so the "Load..." button is working properly now ¯\_(ツ)_/¯ idk what fixed it between the last time I compiled and now.

I will research new libraries either today or tomorrow. If nothing promising comes up, would it be ok to make it clearer why the buttons don't work, eg greying out the buttons and adding a tooltip that says what's wrong?

The buttons in the debugger still don't work properly but that should be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants