Skip to content

Commit c35001f

Browse files
committed
fix: remove sniffer plugin and comments
1 parent 6cdb1ca commit c35001f

File tree

1 file changed

+10
-24
lines changed

1 file changed

+10
-24
lines changed

pom.xml

+10-24
Original file line numberDiff line numberDiff line change
@@ -241,33 +241,14 @@
241241
<autoReleaseAfterClose>true</autoReleaseAfterClose>
242242
</configuration>
243243
</plugin>
244-
<plugin>
245-
<groupId>org.codehaus.mojo</groupId>
246-
<artifactId>animal-sniffer-maven-plugin</artifactId>
247-
<version>1.22</version>
248-
<configuration>
249-
<signature>
250-
<groupId>org.codehaus.mojo.signature</groupId>
251-
<artifactId>java18</artifactId>
252-
<version>1.0</version>
253-
</signature>
254-
<ignores>
255-
java.net.http.*
256-
</ignores>
257-
</configuration>
258-
<!--<executions>
259-
<execution>
260-
<id>ensure-java-1.8-class-library</id>
261-
<phase>test</phase>
262-
<goals>
263-
<goal>check</goal>
264-
</goals>
265-
</execution>
266-
</executions>-->
267-
</plugin>
268244
</plugins>
269245
</pluginManagement>
270246
<plugins>
247+
<!--
248+
This plugin is used to generate AOT metadata during tests so that it can be
249+
compared against those in META-INF/native-image/org.kohsuke/github-api/*.
250+
The tests are located in src/test/java/org.kohsuke.aot
251+
-->
271252
<plugin>
272253
<groupId>org.springframework.boot</groupId>
273254
<artifactId>spring-boot-maven-plugin</artifactId>
@@ -511,6 +492,10 @@
511492
<version>${hamcrest.version}</version>
512493
<scope>test</scope>
513494
</dependency>
495+
<!--
496+
This plugin is used to start a spring boot application during tests
497+
to generate AOT metadata. See also spring-boot-maven-plugin
498+
-->
514499
<dependency>
515500
<groupId>org.springframework.boot</groupId>
516501
<artifactId>spring-boot-starter-test</artifactId>
@@ -548,6 +533,7 @@
548533
<version>4.2.1</version>
549534
<scope>test</scope>
550535
</dependency>
536+
<!-- junit vintage engine is used because junit4 and junit5 tests are required -->
551537
<dependency>
552538
<groupId>org.junit.vintage</groupId>
553539
<artifactId>junit-vintage-engine</artifactId>

0 commit comments

Comments
 (0)