Skip to content

Commit 3fd56dc

Browse files
edbeechinglewtun
andauthored
fix uv env path + details (#188)
* fix uv env path + details * Update slurm/grpo.slurm --------- Co-authored-by: lewtun <[email protected]>
1 parent 138df0c commit 3fd56dc

File tree

6 files changed

+7
-8
lines changed

6 files changed

+7
-8
lines changed

slurm/eval_callback.slurm

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88

99
set -x -e
1010
source ~/.bashrc
11-
conda activate openr1
12-
11+
source openr1/bin/activate
1312
TASK_NAME=$1
1413
TASKS=$2
1514
MODEL_ID=$3
@@ -31,7 +30,7 @@ fi
3130

3231
LM_EVAL_REPO_ID="open-r1/open-r1-eval-leaderboard"
3332
MODEL_NAME=$(echo $MODEL_ID | sed 's/\//_/g') # replaces / with _
34-
DETAILS_REPO_ID="open-r1//details-$MODEL_NAME"
33+
DETAILS_REPO_ID="open-r1/details-$MODEL_NAME"
3534
OUTPUT_DIR="eval_results/$MODEL_ID/$MODEL_REVISION/$TASK_NAME"
3635
# We need this flag since we run this script from training jobs that use DeepSpeed and the env vars get progated which causes errors during evaluation
3736
ACCELERATE_USE_DEEPSPEED=false

slurm/evaluate.slurm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
set -x -e
1515

1616
source ~/.bashrc
17-
conda activate openr1
17+
source openr1/bin/activate
1818
module load cuda/12.1
1919
echo "START TIME: $(date)"
2020
echo "PYTHON ENV: $(which python)"

slurm/generate.slurm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export LD_LIBRARY_PATH=.venv/lib/python3.11/site-packages/nvidia/nvjitlink/lib
129129
echo "SLURM_JOB_ID: $SLURM_JOB_ID"
130130
echo "SLURM_JOB_NODELIST: $SLURM_JOB_NODELIST"
131131

132-
source .venv/bin/activate
132+
source openr1/bin/activate
133133

134134
# Getting the node names
135135
nodes=$(scontrol show hostnames "$SLURM_JOB_NODELIST")

slurm/grpo.slurm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
set -x -e
1212

1313
source ~/.bashrc
14-
conda activate openr1
14+
source openr1/bin/activate
1515
echo "START TIME: $(date)"
1616
echo "PYTHON ENV: $(which python)"
1717

slurm/sft.slurm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
set -x -e
1212

1313
source ~/.bashrc
14-
conda activate openr1
14+
source openr1/bin/activate
1515
echo "START TIME: $(date)"
1616
echo "PYTHON ENV: $(which python)"
1717

src/open_r1/utils/upload_details.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class ScriptArguments:
3939

4040
def main():
4141
parser = HfArgumentParser(ScriptArguments)
42-
args = parser.parse()
42+
args = parser.parse_args_into_dataclasses()[0]
4343

4444
if all(file.endswith(".json") for file in args.data_files):
4545
ds = load_dataset("json", data_files=args.data_files)

0 commit comments

Comments
 (0)