Skip to content

Commit 63f2943

Browse files
ashnashahgroverpetermetz
authored andcommitted
fix(test-tooling): use of hardcoded password
Primary Changes ---------------- 1. BREAKING CHANGE: "password" is now a mandatory parameter of the newEthPersonalAccount function defined in openethereum-test-ledger.ts. It was previously optional. 2. Updated line 236 in openethereum-test-ledger.ts so the default password argument to the newEthPersonalAccount function is not hardcoded. Fixes #2766 Signed-off-by: ashnashahgrover <[email protected]>
1 parent 164addf commit 63f2943

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/cactus-test-tooling/src/main/typescript/openethereum/openethereum-test-ledger.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export class OpenEthereumTestLedger {
233233
*/
234234
public async newEthPersonalAccount(
235235
seedMoney = 10e8,
236-
password = "test",
236+
password: string,
237237
): Promise<string> {
238238
const account = await this.web3.eth.personal.newAccount(password);
239239

0 commit comments

Comments
 (0)