Skip to content

Commit 63f5ff6

Browse files
Zzockerpetermetz
authored andcommitted
fix(connector-xdai): web3.eth.estimateGas, works considering called solidity method do not throw an exception. So, for method having modifier with access control on msg.sender calling estimateGas without from field throws error.to make it work ,transactionConfig.from = web3SigningCredential.ethAccount before calling estimateGas
Signed-off-by: Pritam Singh <[email protected]>
1 parent 70f4005 commit 63f5ff6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/cactus-plugin-ledger-connector-xdai/src/main/typescript/plugin-ledger-connector-xdai.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -292,10 +292,10 @@ export class PluginLedgerConnectorXdai
292292
const payload = (method.send as any).request();
293293
const { params } = payload;
294294
const [transactionConfig] = params;
295+
transactionConfig.from = web3SigningCredential.ethAccount;
295296
if (req.gas == undefined) {
296297
req.gas = await this.web3.eth.estimateGas(transactionConfig);
297298
}
298-
transactionConfig.from = web3SigningCredential.ethAccount;
299299
transactionConfig.gas = req.gas;
300300
transactionConfig.gasPrice = req.gasPrice;
301301
transactionConfig.value = req.value;

0 commit comments

Comments
 (0)