Skip to content

Commit b298b76

Browse files
committed
fix(tools): use latest fabric bootstrap.sh script for AIO image
Fabric appears to have embraced inclusive naming for their branches and deleted the previous default branch of theirs which all the older revisions of their bootstrap.sh script is pointing to by way of attempint to check that branch out. This broke our containers at runtime because the old bootstrap scripts are now crashing due to the non-existent branch. Updated both the 1.4.x and the 2.x dockerfiles to use the current latest bootstrap.sh script instead in order to alleviate the problem. Signed-off-by: Peter Somogyvari <[email protected]>
1 parent 61ce755 commit b298b76

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

tools/docker/fabric-all-in-one/Dockerfile_v1.4.x

+2-2
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ RUN cp $CACTUS_CFG_PATH/fabric-aio-image.pub ~/.ssh/authorized_keys
8484
# flag to avoid pulling docker images because during the build phase of this image
8585
# there is no docker daemon running yet so this has to happen in the CMD once a
8686
# container has been started from the image => see ./run-fabric-network-sh
87-
RUN curl -sSL https://raw.githubusercontent.com/hyperledger/fabric/release-2.2/scripts/bootstrap.sh > /bootstrap.sh
87+
RUN curl -sSL https://raw.githubusercontent.com/hyperledger/fabric/54e27a66812845985c5c067d7f5244a05c6e719b/scripts/bootstrap.sh > /bootstrap.sh
8888
RUN chmod +x bootstrap.sh
8989
# Run the bootstrap here so that at least we can pre-fetch the git clone and the binary downloads resulting in
9090
# faster container startup speed since these steps will not have to be done, only the docker image pulls.
@@ -98,7 +98,7 @@ COPY supervisord.conf /etc/supervisord.conf
9898
COPY run-fabric-network.sh /
9999
COPY healthcheck.sh /
100100
101-
# OpenSSH Server (needed for chaincode deployment )
101+
# OpenSSH Server (needed for chaincode deployment )
102102
EXPOSE 22
103103
104104
# supervisord web ui/dashboard

tools/docker/fabric-all-in-one/Dockerfile_v2.x

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ RUN /download-frozen-image-v2.sh /etc/hyperledger/fabric/ hyperledger/fabric-ca:
142142
# Download and execute the Fabric bootstrap script, but instruct it with the -d
143143
# flag to avoid pulling docker images because during the build phase of this image
144144
# there is no docker daemon running yet
145-
RUN curl -sSL https://raw.githubusercontent.com/hyperledger/fabric/2f69b4222e9c9090b5c1ca235c1b59687566f13e/scripts/bootstrap.sh > /bootstrap.sh
145+
RUN curl -sSL https://raw.githubusercontent.com/hyperledger/fabric/54e27a66812845985c5c067d7f5244a05c6e719b/scripts/bootstrap.sh > /bootstrap.sh
146146
RUN chmod +x bootstrap.sh
147147
# Run the bootstrap here so that at least we can pre-fetch the git clone and the binary downloads resulting in
148148
# faster container startup speed since these steps will not have to be done, only the docker image pulls.

0 commit comments

Comments
 (0)