Skip to content

Commit eb5d1df

Browse files
committed
fix(cmd-api-server): drop URI type alt name from self signed TLS cert
The test verifying mTLS support was failing on NodeJS v16 with the error below which was traced back to the fact that the URL constructor fails with "localhost" as an input at the verify server identity phase. This seems like a bug in NodeJS, but maybe it works as intended. TypeError [ERR_INVALID_URL]: Invalid URL: localhost at new NodeError (node:internal/errors:363:5) at onParseError (node:internal/url:537:9) at new URL (node:internal/url:613:5) at node:tls:247:21 at Array.forEach (<anonymous>) at Object.checkServerIdentity (node:tls:243:5) at TLSSocket.onConnectSecure (node:_tls_wrap:1551:27) at TLSSocket.emit (node:events:365:28) at TLSSocket._finishInit (node:_tls_wrap:952:8) at TLSWrap.ssl.onhandshakedone (node:_tls_wrap:723:12) Signed-off-by: Peter Somogyvari <[email protected]>
1 parent 2195b6b commit eb5d1df

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

packages/cactus-cmd-api-server/src/main/typescript/config/self-signed-pki-generator.ts

-4
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,6 @@ export class SelfSignedPkiGenerator {
139139
{
140140
name: "subjectAltName",
141141
altNames: [
142-
{
143-
type: 6, // URI
144-
value: "localhost",
145-
},
146142
{
147143
type: 7, // IP
148144
ip: "127.0.0.1",

0 commit comments

Comments
 (0)