-
Notifications
You must be signed in to change notification settings - Fork 299
refactor: discontinue dedicated HTTP listeners (ExpressJS apps) for web service plugins #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey, I am new to HL Cactus and would like to start contributing to this project. Can I try working on this issue? |
@siv2r Welcome to the project! Yeah, I think this is a good one to get started on, it's mostly just demolition work (deleting code). |
hey @siv2r are you still working on this? Or can I pick this up? |
Sure, you can take it up.
…On Thu, 10 Jun 2021, 3:32 pm TonyRowntree, ***@***.***> wrote:
hey @siv2r <https://github.com/siv2r> are you still working on this? Or
can I pick this up?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#358 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANSAPHQ7GMOGV2XP67YVWT3TSCEVBANCNFSM4TKVGJ4Q>
.
|
Also delete from the connector interface |
@TonyRowntree Is it cool if I reassign this to @Leeyoungone ? |
Sure thing! 👍 |
@Leeyoungone Please make a comment on the issue to enable assignment. |
Thank you for letting me pick this up! |
…plugins Fixes hyperledger-cacti#358 Signed-off-by: TonyRowntree [email protected] Signed-off-by: Youngone Lee <[email protected]>
…plugins Fixes hyperledger-cacti#358 Signed-off-by: TonyRowntree [email protected] Signed-off-by: Youngone Lee <[email protected]>
…plugins Fixes #358 Signed-off-by: TonyRowntree [email protected] Signed-off-by: Youngone Lee <[email protected]>
…plugins Fixes hyperledger-cacti#358 Signed-off-by: TonyRowntree [email protected] Signed-off-by: Youngone Lee <[email protected]>
…plugins Fixes hyperledger-cacti#358 Signed-off-by: TonyRowntree [email protected] Signed-off-by: Youngone Lee <[email protected]>
…plugins Fixes hyperledger-cacti#358 Signed-off-by: TonyRowntree [email protected] Signed-off-by: Youngone Lee <[email protected]>
…plugins Fixes hyperledger-cacti#358 Signed-off-by: TonyRowntree [email protected] Signed-off-by: Youngone Lee <[email protected]>
Updating Golang package versions and dependencies and Re-enabling workflows
Description
Originally we implemented this feature to provide the possibility for deployments to run plugins isolated on separate web domains/network hosts, but with today's code the latter can also be achieved by running multiple API servers which makes the dedicated HTTP listeners of plugins a redundant feature which also throws a wrench into the consortium definition powered routing within nodes.
Added benefit: Make it less confusing to implement plugins.
Examples of the code that is being talked about in this issue:
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-plugin-consortium-manual/src/main/typescript/plugin-consortium-manual.ts#L68
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts#L101
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts#L58
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-plugin-ledger-connector-quorum/src/main/typescript/plugin-ledger-connector-quorum.ts#L73
These shutdown methods on plugin classes could be deleted since this change would place the concern of HTTP listeners back completely to the control of the API server:
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-plugin-consortium-manual/src/main/typescript/plugin-consortium-manual.ts#L45
Also could get rid of these from the common interface definition for web service plugins:
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-core-api/src/main/typescript/plugin/web-service/i-plugin-web-service.ts#L9
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-core-api/src/main/typescript/plugin/web-service/i-plugin-web-service.ts#L10
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-core-api/src/main/typescript/plugin/web-service/i-plugin-web-service.ts#L20
https://github.com/hyperledger/cactus/blob/3f0d86d2d7a95fce63bae2635466644e461d5f3e/packages/cactus-core-api/src/main/typescript/plugin/web-service/i-plugin-web-service.ts#L23
Acceptance Criteria
cc: @sfuji822 @takeutak @jonathan-m-hamilton
The text was updated successfully, but these errors were encountered: