Skip to content

Commit 5b50ade

Browse files
committed
Use a non-hidden filename for coverage files
The `upload-artifact` action recently introduced a change where by default it no longer uploads hidden files. This affected the `.coverage.*` files produced by Python tests. There is an `include-hidden-files: true` option to change this, but so far in our testing it did not work. Fix the issue by changing the file name to be non-hidden. See actions/upload-artifact#602 and https://hypothes-is.slack.com/archives/C4K6M7P5E/p1725285976308269.
1 parent ea1bdd3 commit 5b50ade

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/workflows/ci.yml

+6-2
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,14 @@ jobs:
9595
- run: python -m pip install 'tox<4'
9696
- run: tox -e tests
9797
env:
98-
COVERAGE_FILE: .coverage.${{ matrix.python-version }}
98+
# Use a non-hidden file name to work around issues uploading hidden
99+
# files in `actions/upload-artifact`.
100+
COVERAGE_FILE: coverage.tests
99101
- name: Upload coverage file
100102
uses: actions/upload-artifact@v3
101103
with:
102104
name: coverage
103-
path: .coverage.*
105+
path: coverage.tests
104106
Coverage:
105107
needs: tests
106108
runs-on: ubuntu-latest
@@ -123,6 +125,8 @@ jobs:
123125
name: coverage
124126
- run: python -m pip install 'tox<4'
125127
- run: tox -e coverage
128+
env:
129+
COVERAGE_FILE: coverage.tests
126130
Functests:
127131
runs-on: ubuntu-latest
128132
services:

0 commit comments

Comments
 (0)