Skip to content

Enable EDGE3 Elements in ParsedCurveGenerator #30359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

Enable EDGE3 Elements in ParsedCurveGenerator #30359

wants to merge 1 commit into from

Conversation

miaoyinb
Copy link
Contributor

closes #30337

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 06bd6b9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 06bd6b9 wanted to post the following:

Framework coverage

f301d1 #30359 06bd6b
Total Total +/- New
Rate 85.43% 85.43% +0.00% 100.00%
Hits 112325 112336 +11 24
Misses 19156 19157 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@miaoyinb
Copy link
Contributor Author

Pending libMesh/libmesh#4145

@pbehne pbehne self-assigned this Apr 21, 2025
@pbehne
Copy link
Contributor

pbehne commented Apr 22, 2025

Just let me know when this is ready for a review.

@miaoyinb
Copy link
Contributor Author

@pbehne the test with XYDelaunay will need to wait until the corresponding libMesh PR is merged and reaches here.

We can also merge this first and add the test later. Let me know your preference. Thanks.

@pbehne
Copy link
Contributor

pbehne commented Apr 22, 2025

@pbehne the test with XYDelaunay will need to wait until the corresponding libMesh PR is merged and reaches here.

We can also merge this first and add the test later. Let me know your preference. Thanks.

Sounds good. I'll start the review now so we can have the bulk of it finished in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad will be requested when the pull request is marked ready for review lindsayad is a code owner

@roystgnr roystgnr Awaiting requested review from roystgnr roystgnr will be requested when the pull request is marked ready for review roystgnr is a code owner

@GiudGiud GiudGiud Awaiting requested review from GiudGiud GiudGiud will be requested when the pull request is marked ready for review GiudGiud is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pbehne pbehne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Quadratic Elements in ParsedCurveGenerator
3 participants
@miaoyinb @moosebuild @pbehne