Skip to content

Commit dfe3cfc

Browse files
cbornetwing328
authored andcommitted
[Flask] Upgrade to flask connexion 2.0.0rc3 (OpenAPITools#1192)
1 parent 67fd3cc commit dfe3cfc

File tree

8 files changed

+51
-55
lines changed

8 files changed

+51
-55
lines changed

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PythonFlaskConnexionServerCodegen.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,7 @@ public String getSchemaType(Schema p) {
318318

319319
@Override
320320
public void preprocessOpenAPI(OpenAPI openAPI) {
321-
// need vendor extensions for x-swagger-router-controller
322-
// can be changed to x-openapi-router-controller when https://github.com/zalando/connexion/issues/683 is done
321+
// need vendor extensions for x-openapi-router-controller
323322
Map<String, PathItem> paths = openAPI.getPaths();
324323
if (paths != null) {
325324
for (String pathname : paths.keySet()) {
@@ -337,9 +336,9 @@ public void preprocessOpenAPI(OpenAPI openAPI) {
337336
operationId = getOrGenerateOperationId(operation, pathname, method.toString());
338337
}
339338
operation.setOperationId(toOperationId(operationId));
340-
if (operation.getExtensions() == null || operation.getExtensions().get("x-swagger-router-controller") == null) {
339+
if (operation.getExtensions() == null || operation.getExtensions().get("x-openapi-router-controller") == null) {
341340
operation.addExtension(
342-
"x-swagger-router-controller",
341+
"x-openapi-router-controller",
343342
controllerPackage + "." + toApiFilename(tag)
344343
);
345344
}

modules/openapi-generator/src/main/resources/flaskConnexion/requirements.mustache

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
# Install flask-connexion from git branch dev-2.0. Change when connexion 2.0 is released
2-
git+https://github.com/zalando/connexion.git@35e4e678ef69e703eaf84a48126049808c73b17c#egg=connexion
3-
swagger-ui-bundle
1+
connexion == 2.0.0rc3
2+
swagger-ui-bundle == 0.0.2
43
python_dateutil == 2.6.0
54
{{#supportPython2}}
65
typing == 3.5.2.2
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.3.0-SNAPSHOT
1+
3.3.1-SNAPSHOT

samples/server/petstore/flaskConnexion-python2/openapi_server/openapi/openapi.yaml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ paths:
4040
summary: Add a new pet to the store
4141
tags:
4242
- pet
43-
x-swagger-router-controller: openapi_server.controllers.pet_controller
43+
x-openapi-router-controller: openapi_server.controllers.pet_controller
4444
put:
4545
operationId: update_pet
4646
requestBody:
@@ -70,7 +70,7 @@ paths:
7070
summary: Update an existing pet
7171
tags:
7272
- pet
73-
x-swagger-router-controller: openapi_server.controllers.pet_controller
73+
x-openapi-router-controller: openapi_server.controllers.pet_controller
7474
/pet/findByStatus:
7575
get:
7676
description: Multiple status values can be provided with comma separated strings
@@ -115,7 +115,7 @@ paths:
115115
summary: Finds Pets by status
116116
tags:
117117
- pet
118-
x-swagger-router-controller: openapi_server.controllers.pet_controller
118+
x-openapi-router-controller: openapi_server.controllers.pet_controller
119119
/pet/findByTags:
120120
get:
121121
deprecated: true
@@ -156,7 +156,7 @@ paths:
156156
summary: Finds Pets by tags
157157
tags:
158158
- pet
159-
x-swagger-router-controller: openapi_server.controllers.pet_controller
159+
x-openapi-router-controller: openapi_server.controllers.pet_controller
160160
/pet/{petId}:
161161
delete:
162162
operationId: delete_pet
@@ -183,7 +183,7 @@ paths:
183183
summary: Deletes a pet
184184
tags:
185185
- pet
186-
x-swagger-router-controller: openapi_server.controllers.pet_controller
186+
x-openapi-router-controller: openapi_server.controllers.pet_controller
187187
get:
188188
description: Returns a single pet
189189
operationId: get_pet_by_id
@@ -216,7 +216,7 @@ paths:
216216
summary: Find pet by ID
217217
tags:
218218
- pet
219-
x-swagger-router-controller: openapi_server.controllers.pet_controller
219+
x-openapi-router-controller: openapi_server.controllers.pet_controller
220220
post:
221221
operationId: update_pet_with_form
222222
parameters:
@@ -249,7 +249,7 @@ paths:
249249
summary: Updates a pet in the store with form data
250250
tags:
251251
- pet
252-
x-swagger-router-controller: openapi_server.controllers.pet_controller
252+
x-openapi-router-controller: openapi_server.controllers.pet_controller
253253
/pet/{petId}/uploadImage:
254254
post:
255255
operationId: upload_file
@@ -287,7 +287,7 @@ paths:
287287
summary: uploads an image
288288
tags:
289289
- pet
290-
x-swagger-router-controller: openapi_server.controllers.pet_controller
290+
x-openapi-router-controller: openapi_server.controllers.pet_controller
291291
/store/inventory:
292292
get:
293293
description: Returns a map of status codes to quantities
@@ -307,7 +307,7 @@ paths:
307307
summary: Returns pet inventories by status
308308
tags:
309309
- store
310-
x-swagger-router-controller: openapi_server.controllers.store_controller
310+
x-openapi-router-controller: openapi_server.controllers.store_controller
311311
/store/order:
312312
post:
313313
operationId: place_order
@@ -334,7 +334,7 @@ paths:
334334
summary: Place an order for a pet
335335
tags:
336336
- store
337-
x-swagger-router-controller: openapi_server.controllers.store_controller
337+
x-openapi-router-controller: openapi_server.controllers.store_controller
338338
/store/order/{orderId}:
339339
delete:
340340
description: For valid response try integer IDs with value < 1000. Anything above 1000 or nonintegers will generate API errors
@@ -356,7 +356,7 @@ paths:
356356
summary: Delete purchase order by ID
357357
tags:
358358
- store
359-
x-swagger-router-controller: openapi_server.controllers.store_controller
359+
x-openapi-router-controller: openapi_server.controllers.store_controller
360360
get:
361361
description: For valid response try integer IDs with value <= 5 or > 10. Other values will generated exceptions
362362
operationId: get_order_by_id
@@ -389,7 +389,7 @@ paths:
389389
summary: Find purchase order by ID
390390
tags:
391391
- store
392-
x-swagger-router-controller: openapi_server.controllers.store_controller
392+
x-openapi-router-controller: openapi_server.controllers.store_controller
393393
/user:
394394
post:
395395
description: This can only be done by the logged in user.
@@ -408,7 +408,7 @@ paths:
408408
summary: Create user
409409
tags:
410410
- user
411-
x-swagger-router-controller: openapi_server.controllers.user_controller
411+
x-openapi-router-controller: openapi_server.controllers.user_controller
412412
/user/createWithArray:
413413
post:
414414
operationId: create_users_with_array_input
@@ -428,7 +428,7 @@ paths:
428428
summary: Creates list of users with given input array
429429
tags:
430430
- user
431-
x-swagger-router-controller: openapi_server.controllers.user_controller
431+
x-openapi-router-controller: openapi_server.controllers.user_controller
432432
/user/createWithList:
433433
post:
434434
operationId: create_users_with_list_input
@@ -448,7 +448,7 @@ paths:
448448
summary: Creates list of users with given input array
449449
tags:
450450
- user
451-
x-swagger-router-controller: openapi_server.controllers.user_controller
451+
x-openapi-router-controller: openapi_server.controllers.user_controller
452452
/user/login:
453453
get:
454454
operationId: login_user
@@ -492,7 +492,7 @@ paths:
492492
summary: Logs user into the system
493493
tags:
494494
- user
495-
x-swagger-router-controller: openapi_server.controllers.user_controller
495+
x-openapi-router-controller: openapi_server.controllers.user_controller
496496
/user/logout:
497497
get:
498498
operationId: logout_user
@@ -503,7 +503,7 @@ paths:
503503
summary: Logs out current logged in user session
504504
tags:
505505
- user
506-
x-swagger-router-controller: openapi_server.controllers.user_controller
506+
x-openapi-router-controller: openapi_server.controllers.user_controller
507507
/user/{username}:
508508
delete:
509509
description: This can only be done by the logged in user.
@@ -525,7 +525,7 @@ paths:
525525
summary: Delete user
526526
tags:
527527
- user
528-
x-swagger-router-controller: openapi_server.controllers.user_controller
528+
x-openapi-router-controller: openapi_server.controllers.user_controller
529529
get:
530530
operationId: get_user_by_name
531531
parameters:
@@ -554,7 +554,7 @@ paths:
554554
summary: Get user by user name
555555
tags:
556556
- user
557-
x-swagger-router-controller: openapi_server.controllers.user_controller
557+
x-openapi-router-controller: openapi_server.controllers.user_controller
558558
put:
559559
description: This can only be done by the logged in user.
560560
operationId: update_user
@@ -582,7 +582,7 @@ paths:
582582
summary: Updated user
583583
tags:
584584
- user
585-
x-swagger-router-controller: openapi_server.controllers.user_controller
585+
x-openapi-router-controller: openapi_server.controllers.user_controller
586586
components:
587587
schemas:
588588
Order:
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
# Install flask-connexion from git branch dev-2.0. Change when connexion 2.0 is released
2-
git+https://github.com/zalando/connexion.git@35e4e678ef69e703eaf84a48126049808c73b17c#egg=connexion
3-
swagger-ui-bundle
1+
connexion == 2.0.0rc3
2+
swagger-ui-bundle == 0.0.2
43
python_dateutil == 2.6.0
54
typing == 3.5.2.2
65
setuptools >= 21.0.0
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.3.0-SNAPSHOT
1+
3.3.1-SNAPSHOT

0 commit comments

Comments
 (0)