Skip to content

Multiplying by 2.5 in channel alpha? #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jensdebruijn opened this issue Feb 24, 2025 · 3 comments
Open

Multiplying by 2.5 in channel alpha? #181

jensdebruijn opened this issue Feb 24, 2025 · 3 comments

Comments

@jensdebruijn
Copy link
Contributor

channelAlpha is multiplied by 2.5 here, but it is not clear (to me ;-)), why this is done.

self.var.channelAlpha = alpTermChan * (self.var.chanWettedPerimeterAlpha ** self.var.alpPower) *2.5

It seems different from the CWatM paper (eq.21) : https://gmd.copernicus.org/articles/13/3267/2020/

And also different from the PCR-GLOBWB implementation

https://github.com/UU-Hydro/PCR-GLOBWB_model/blob/2e3a5d85b0a1c264c7cb22dbc864bce87d115053/model/routing.py#L1243

@dof1985
Copy link
Contributor

dof1985 commented Feb 24, 2025

@PeterBurek
Copy link
Contributor

Jens I guess you found a bug. The 2.5 does not make sense at all. I think it was in to test the sensitivity and never taken out.

We have no the problem that the change in the source code would require a change in all our calibrations or at least putting a
factor in for all calibration for the calibration parameter manningsN

self.var.chanMan = loadmap('chanMan') * manningsFactor
alpTermChan = (self.var.chanMan / (np.sqrt(self.var.chanGrad))) ** self.var.beta
self.var.channelAlpha = alpTermChan * (self.var.chanWettedPerimeterAlpha ** self.var.alpPower) *2.5

The calibration parameter manningsN compensates somehow for the 2.5 factor.
I guess we will remove the 2.5 in the following releases. But till then we leave it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants