Skip to content

clippy is now nagging about pbjson's generations #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kampfkarren opened this issue Jan 5, 2025 · 1 comment · May be fixed by #138
Open

clippy is now nagging about pbjson's generations #137

Kampfkarren opened this issue Jan 5, 2025 · 1 comment · May be fixed by #138

Comments

@Kampfkarren
Copy link

My clippy outputs are now spammed with this:

warning: the following explicit lifetimes could be elided: 'de
     --> /mnt/e/User/Documents/projects/rust/ytmnd-backend/target/debug/build/ytmnd-backend-deec8404a84968ed/out/ytmnd2.serde.rs:11866:22
      |
11866 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
      |                      ^^^                     ^^^
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
      |
11866 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
11866 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
      |

warning: the following explicit lifetimes could be elided: 'de
     --> /mnt/e/User/Documents/projects/rust/ytmnd-backend/target/debug/build/ytmnd-backend-deec8404a84968ed/out/ytmnd2.serde.rs:11949:22
      |
11949 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
      |                      ^^^                     ^^^
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
      |
11949 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
11949 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
      |

warning: the following explicit lifetimes could be elided: 'de
     --> /mnt/e/User/Documents/projects/rust/ytmnd-backend/target/debug/build/ytmnd-backend-deec8404a84968ed/out/ytmnd2.serde.rs:12036:22
      |
12036 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
      |                      ^^^                     ^^^
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
      |
12036 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
12036 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {
      |

warning: the following explicit lifetimes could be elided: 'de
     --> /mnt/e/User/Documents/projects/rust/ytmnd-backend/target/debug/build/ytmnd-backend-deec8404a84968ed/out/ytmnd2.serde.rs:12156:22
      |
12156 |                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
      |                      ^^^                     ^^^
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
      |
12156 -                 impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
12156 +                 impl serde::de::Visitor<'_> for GeneratedVisitor {

etc etc...

@Kampfkarren Kampfkarren linked a pull request Jan 5, 2025 that will close this issue
@MattCairns
Copy link

Is this safe to merge? I am also having this issue and getting ~500 of these errors running clippy - would be nice to have fixed in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants