test: clean up any event listeners

Latest mocha no longer kills the process at the end. So we have to clean
up properly.

Author: justmoon

test/accountSpec.js

@@ -65,6 +65,10 @@ describe('Accounts', function () {
     ])
   })
 
+  afterEach(function () {
+    appHelper.close(this)
+  })
+
   describe('GET /accounts', function () {
     it('should return 200', async function () {
       const account1 = this.adminAccount

test/fulfillmentSpec.js

@@ -49,6 +49,7 @@ describe('GET /fulfillment', function () {
   afterEach(async function () {
     nock.cleanAll()
     this.clock.restore()
+    appHelper.close(this)
   })
 
   it('should return 401 if the request is not authenticated', async function () {
@@ -240,6 +241,7 @@ describe('GET /fulfillment2', function () {
   afterEach(async function () {
     nock.cleanAll()
     this.clock.restore()
+    appHelper.close(this)
   })
 
   it('should return 401 if the request is not authenticated', async function () {
@@ -429,6 +431,7 @@ describe('PUT /fulfillment', function () {
   afterEach(async function () {
     nock.cleanAll()
     this.clock.restore()
+    appHelper.close(this)
   })
 
   it('should return 401 if the request is not authenticated', async function () {
@@ -682,6 +685,7 @@ describe('PUT /fulfillment2', function () {
   afterEach(async function () {
     nock.cleanAll()
     this.clock.restore()
+    appHelper.close(this)
   })
 
   it('should return 401 if the request is not authenticated', async function () {

test/getAuthTokenSpec.js

@@ -25,6 +25,10 @@ describe('GET /auth_token', function () {
     await dbHelper.addAccounts(_.values(_.omit(accounts, 'noBalance')))
   })
 
+  afterEach(function () {
+    appHelper.close(this)
+  })
+
   it('returns 200 and a token on success', async function () {
     await this.request()
       .get('/auth_token')

test/getTransferSpec.js

@@ -50,6 +50,7 @@ describe('GET /transfers/:uuid', function () {
   afterEach(async function () {
     nock.cleanAll()
     this.clock.restore()
+    appHelper.close(this)
   })
 
   it('should return 200 for an existing transfer', async function () {

test/healthSpec.js

@@ -10,24 +10,27 @@ const logger = require('../src/services/log')
 const logHelper = require('./helpers/log')
 const expect = require('chai').expect
 
-function request () {
-  return superagent(app.koa.listen())
-}
-
 describe('Health', function () {
   logHelper(logger)
 
-  before(function * () {
-    yield dbHelper.init()
-    yield dbHelper.clean()
-    yield dbHelper.addAccounts([
+  before(async function () {
+    await dbHelper.init()
+    await dbHelper.clean()
+    await dbHelper.addAccounts([
       accounts.admin
     ])
+
+    this.server = app.koa.listen()
+    this.request = () => superagent(this.server)
+  })
+
+  after(function () {
+    this.server.close()
   })
 
   describe('GET /health', function () {
     it('should return 200 for an authenticated request', async function () {
-      await request()
+      await this.request()
         .get('/health')
         .auth('admin', 'admin')
         .expect(200)
@@ -38,11 +41,10 @@ describe('Health', function () {
         })
     })
 
-    it('should return 401 for an unauthenticated request', function * () {
-      yield request()
+    it('should return 401 for an unauthenticated request', async function () {
+      await this.request()
         .get('/health')
         .expect(401)
-        .end()
     })
   })
 })

test/helpers/app.js

@@ -87,3 +87,7 @@ exports.create = function (context, app) {
     return new WebSocket(processedUri, protocols, options)
   }
 }
+
+exports.close = function (context) {
+  context.server.close()
+}

test/metadataSpec.js

@@ -9,19 +9,24 @@ const app = require('../src/services/app')
 const logger = require('../src/services/log')
 const logHelper = require('./helpers/log')
 
-function request () {
-  return superagent(app.koa.listen())
-}
-
 describe('Metadata', function () {
   logHelper(logger)
 
+  before(function () {
+    this.server = app.koa.listen()
+    this.request = () => superagent(this.server)
+  })
+
+  after(function () {
+    this.server.close()
+  })
+
   delete process.env.LEDGER_AMOUNT_PRECISION
   delete process.env.UNIT_TEST_OVERRIDE
 
   describe('GET /', function () {
     it('should return metadata', async function () {
-      await request()
+      await this.request()
         .get('/')
         .expect(200)
         .expect(function (res) {
@@ -66,7 +71,8 @@ describe('Metadata', function () {
         timerWorker: require('../src/services/timerWorker'),
         notificationBroadcaster: require('../src/services/notificationBroadcaster')
       })
-      const agent = superagent(newApp.koa.listen())
+      const server = newApp.koa.listen()
+      const agent = superagent(server)
 
       await agent
         .get('/')
@@ -105,6 +111,8 @@ describe('Metadata', function () {
       delete process.env.LEDGER_CURRENCY_CODE
       delete process.env.LEDGER_CURRENCY_SYMBOL
       delete process.env.LEDGER_ILP_PREFIX
+
+      server.close()
     })
   })
 })

test/notificationSpec.js

@@ -71,6 +71,7 @@ describe('Notifications', function () {
 
   afterEach(function () {
     this.clock.restore()
+    appHelper.close(this)
   })
 
   describe('GET /websocket as alice (regular user)', function () {
@@ -1019,11 +1020,14 @@ describe('Notifications', function () {
           resolve()
         })
       })
+      this.socket.terminate()
     })
 
-    it('closes the websocket if an invalid token is passed', function (done) {
+    it('closes the websocket if an invalid token is passed', async function () {
       this.socket = this.ws('http://localhost/websocket?token=foo', {})
-      this.socket.on('close', () => done())
+      await new Promise(resolve => {
+        this.socket.on('close', resolve)
+      })
     })
   })
 })

test/postMessageSpec.js

@@ -57,6 +57,7 @@ describe('POST /messages', function () {
 
   afterEach(async function () {
     this.socket.terminate()
+    appHelper.close(this)
   })
 
   it('returns 201 if the message is valid', async function () {

test/putTransferSpec.js

@@ -73,6 +73,7 @@ describe('PUT /transfers/:id', function () {
   afterEach(async function () {
     nock.cleanAll()
     this.clock.restore()
+    appHelper.close(this)
   })
 
   /* Invalid transfer objects */

test/rejectionSpec.js

@@ -57,6 +57,7 @@ describe('PUT /rejection', function () {
   afterEach(async function () {
     nock.cleanAll()
     this.clock.restore()
+    appHelper.close(this)
   })
 
   it('should return 401 if the request is not authenticated', async function () {

test/transferStateSpec.js

@@ -50,6 +50,7 @@ describe('Transfer State', function () {
 
   afterEach(async function () {
     this.clock.restore()
+    appHelper.close(this)
   })
 
   describe('GET /transfers/:uuid/state', function () {