Skip to content

Commit 46e2aa3

Browse files
committed
values: add extraEnvVars to the invenio block
* Deprecates `invenio.extra_env_from_secret`.
1 parent 7aea719 commit 46e2aa3

File tree

6 files changed

+32
-13
lines changed

6 files changed

+32
-13
lines changed

charts/invenio/templates/NOTES.txt

+15-7
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,25 @@ Your release is named {{ .Release.Name }}.
44

55
{{- if .Values.invenio.extra_config}}
66

7-
DEPRECATION WARNING:
7+
DEPRECATION WARNING:
88
`invenio.extra_config` has been renamed to `invenio.extraConfig` and will be
99
removed in a future release.
1010

1111
{{- end }}
1212

1313
{{- if .Values.invenio.sentry.existing_secret }}
1414

15-
DEPRECATION WARNING:
16-
`invenio.sentry.existing_secret` has been renamed to `invenio.sentry.existingSecret`
15+
DEPRECATION WARNING:
16+
`invenio.sentry.existing_secret` has been renamed to `invenio.sentry.existingSecret`
1717
and its type has changed from boolean to string.
1818
This key will be removed in a future release.
1919

2020
{{- end }}
2121

2222
{{- if .Values.invenio.sentry.secret_name }}
2323

24-
DEPRECATION WARNING:
25-
`invenio.sentry.secret_name` has been removed in favor of
24+
DEPRECATION WARNING:
25+
`invenio.sentry.secret_name` has been removed in favor of
2626
`invenio.sentry.existingSecret` will be removed in a future release.
2727

2828
{{- end }}
@@ -47,7 +47,7 @@ DEPRECATION WARNING:
4747

4848
{{- if .Values.invenio.datacite.existing_secret }}
4949

50-
DEPRECATION WARNING:
50+
DEPRECATION WARNING:
5151
`invenio.datacite.existing_secret` has been renamed to `invenio.datacite.existingSecret`
5252
and its type has changed from boolean to string.
5353
This key will be removed in a future release.
@@ -56,8 +56,16 @@ DEPRECATION WARNING:
5656

5757
{{- if .Values.invenio.datacite.secret_name }}
5858

59-
DEPRECATION WARNING:
59+
DEPRECATION WARNING:
6060
`invenio.datacite.secret_name` has been renamed in favor of
6161
`invenio.datacite.existingSecret` will be removed in a future release.
6262

6363
{{- end }}
64+
65+
{{- if .Values.invenio.extra_env_from_secret }}
66+
67+
DEPRECATION WARNING:
68+
`invenio.extra_env_from_secret` will be removed in future a release.
69+
Use `invenio.extraEnvFrom` or `invenio.extraEnvVars` instead.
70+
71+
{{- end }}

charts/invenio/templates/install-init-job.yaml

+4-1
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,16 @@ spec:
3333
envFrom:
3434
- configMapRef:
3535
name: {{ include "invenio.fullname" . }}-config
36-
- secretRef:
36+
- secretRef:
3737
name: {{ include "invenio.secretName" . }}
3838
env:
3939
- name: TZ
4040
value: {{ required "Missing .Values.global.timezone" .Values.global.timezone }}
4141
{{- include "invenio.config.queue" . | nindent 8 }}
4242
{{- include "invenio.config.database" . | nindent 8 }}
43+
{{- with .Values.invenio.extraEnvVars }}
44+
{{- toYaml . | nindent 8 }}
45+
{{- end }}
4346
volumeMounts:
4447
{{- range $key, $value := .Values.invenio.vocabularies }}
4548
- name: vocabularies

charts/invenio/templates/web-deployment.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ spec:
5252
value: {{ required "Missing .Values.global.timezone" .Values.global.timezone }}
5353
{{- include "invenio.config.queue" . | nindent 8 }}
5454
{{- include "invenio.config.database" . | nindent 8 }}
55+
{{- with .Values.invenio.extraEnvVars }}
56+
{{- toYaml . | nindent 8 }}
57+
{{- end }}
5558
{{- with .Values.web.extraEnvVars }}
5659
{{- toYaml . | nindent 8 }}
5760
{{- end }}

charts/invenio/templates/worker-beat-deployment.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ spec:
6464
value: {{ required "Missing .Values.global.timezone" .Values.global.timezone }}
6565
{{- include "invenio.config.queue" . | nindent 8 }}
6666
{{- include "invenio.config.database" . | nindent 8}}
67+
{{- with .Values.invenio.extraEnvVars }}
68+
{{- toYaml . | nindent 8 }}
69+
{{- end }}
6770
{{- with .Values.workerBeat.extraEnvVars }}
6871
{{- toYaml . | nindent 8 }}
6972
{{- end }}

charts/invenio/templates/worker-deployment.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ spec:
5555
value: {{ required "Missing .Values.global.timezone" .Values.global.timezone }}
5656
{{- include "invenio.config.queue" . | nindent 10 }}
5757
{{- include "invenio.config.database" . | nindent 10 }}
58+
{{- with .Values.invenio.extraEnvVars }}
59+
{{- toYaml . | nindent 10 }}
60+
{{- end }}
5861
{{- with .Values.worker.extraEnvVars }}
5962
{{- toYaml . | nindent 10 }}
6063
{{- end }}

charts/invenio/values.yaml

+4-5
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,11 @@ invenio:
9999
## @param invenio.extraConfig Extra environment variables (templated) to be added to all the pods.
100100
##
101101
extraConfig: {}
102+
## @param invenio.extra_env_from_secret DEPRECATED: invenio.extraEnvFromSecret instead
102103
extra_env_from_secret: []
103-
# - name: NAME_OF_MY_ENV_VAR
104-
# valueFrom:
105-
# secretKeyRef:
106-
# name: name-of-my-secret
107-
# key: KEY_IN_MY_SECRET
104+
## @param invenio.extraEnvVars Extra environment variables (templated) to be added to all the pods.
105+
##
106+
extraEnvVars: []
108107
uwsgiExtraConfig: {}
109108
## @param invenio.extraEnvFrom Extra secretRef or configMapRef for the `envFrom` field in all Invenio containers
110109
##

0 commit comments

Comments
 (0)