Skip to content

Commit c20baf5

Browse files
authored
values: add extraEnvVars to the invenio block
* Deprecates `invenio.extra_env_from_secret`.
1 parent 69c204f commit c20baf5

File tree

6 files changed

+35
-16
lines changed

6 files changed

+35
-16
lines changed

charts/invenio/templates/NOTES.txt

+15-7
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,25 @@ Your release is named {{ .Release.Name }}.
44

55
{{- if .Values.invenio.extra_config}}
66

7-
DEPRECATION WARNING:
7+
DEPRECATION WARNING:
88
`invenio.extra_config` has been renamed to `invenio.extraConfig` and will be
99
removed in a future release.
1010

1111
{{- end }}
1212

1313
{{- if .Values.invenio.sentry.existing_secret }}
1414

15-
DEPRECATION WARNING:
16-
`invenio.sentry.existing_secret` has been renamed to `invenio.sentry.existingSecret`
15+
DEPRECATION WARNING:
16+
`invenio.sentry.existing_secret` has been renamed to `invenio.sentry.existingSecret`
1717
and its type has changed from boolean to string.
1818
This key will be removed in a future release.
1919

2020
{{- end }}
2121

2222
{{- if .Values.invenio.sentry.secret_name }}
2323

24-
DEPRECATION WARNING:
25-
`invenio.sentry.secret_name` has been removed in favor of
24+
DEPRECATION WARNING:
25+
`invenio.sentry.secret_name` has been removed in favor of
2626
`invenio.sentry.existingSecret` will be removed in a future release.
2727

2828
{{- end }}
@@ -47,7 +47,7 @@ DEPRECATION WARNING:
4747

4848
{{- if .Values.invenio.datacite.existing_secret }}
4949

50-
DEPRECATION WARNING:
50+
DEPRECATION WARNING:
5151
`invenio.datacite.existing_secret` has been renamed to `invenio.datacite.existingSecret`
5252
and its type has changed from boolean to string.
5353
This key will be removed in a future release.
@@ -56,7 +56,7 @@ DEPRECATION WARNING:
5656

5757
{{- if .Values.invenio.datacite.secret_name }}
5858

59-
DEPRECATION WARNING:
59+
DEPRECATION WARNING:
6060
`invenio.datacite.secret_name` has been renamed in favor of
6161
`invenio.datacite.existingSecret` will be removed in a future release.
6262

@@ -108,3 +108,11 @@ https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
108108
{{/*
109109
END: Warning on unset resources.
110110
*/}}
111+
112+
{{- if .Values.invenio.extra_env_from_secret }}
113+
114+
DEPRECATION WARNING:
115+
`invenio.extra_env_from_secret` will be removed in future a release.
116+
Use `invenio.extraEnvFrom` or `invenio.extraEnvVars` instead.
117+
118+
{{- end }}

charts/invenio/templates/install-init-job.yaml

+4-1
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,16 @@ spec:
3333
envFrom:
3434
- configMapRef:
3535
name: {{ include "invenio.fullname" . }}-config
36-
- secretRef:
36+
- secretRef:
3737
name: {{ include "invenio.secretName" . }}
3838
env:
3939
- name: TZ
4040
value: {{ required "Missing .Values.global.timezone" .Values.global.timezone }}
4141
{{- include "invenio.config.queue" . | nindent 8 }}
4242
{{- include "invenio.config.database" . | nindent 8 }}
43+
{{- with .Values.invenio.extraEnvVars }}
44+
{{- toYaml . | nindent 8 }}
45+
{{- end }}
4346
volumeMounts:
4447
{{- range $key, $value := .Values.invenio.vocabularies }}
4548
- name: vocabularies

charts/invenio/templates/web-deployment.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ spec:
5050
value: {{ required "Missing .Values.global.timezone" .Values.global.timezone }}
5151
{{- include "invenio.config.queue" . | nindent 8 }}
5252
{{- include "invenio.config.database" . | nindent 8 }}
53+
{{- with .Values.invenio.extraEnvVars }}
54+
{{- toYaml . | nindent 8 }}
55+
{{- end }}
5356
{{- with .Values.web.extraEnvVars }}
5457
{{- toYaml . | nindent 8 }}
5558
{{- end }}

charts/invenio/templates/worker-beat-deployment.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ spec:
6464
value: {{ required "Missing .Values.global.timezone" .Values.global.timezone }}
6565
{{- include "invenio.config.queue" . | nindent 8 }}
6666
{{- include "invenio.config.database" . | nindent 8}}
67+
{{- with .Values.invenio.extraEnvVars }}
68+
{{- toYaml . | nindent 8 }}
69+
{{- end }}
6770
{{- with .Values.workerBeat.extraEnvVars }}
6871
{{- toYaml . | nindent 8 }}
6972
{{- end }}

charts/invenio/templates/worker-deployment.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ spec:
5353
value: {{ required "Missing .Values.global.timezone" .Values.global.timezone }}
5454
{{- include "invenio.config.queue" . | nindent 10 }}
5555
{{- include "invenio.config.database" . | nindent 10 }}
56+
{{- with .Values.invenio.extraEnvVars }}
57+
{{- toYaml . | nindent 10 }}
58+
{{- end }}
5659
{{- with .Values.worker.extraEnvVars }}
5760
{{- toYaml . | nindent 10 }}
5861
{{- end }}

charts/invenio/values.yaml

+7-8
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,11 @@ invenio:
9999
## @param invenio.extraConfig Extra environment variables (templated) to be added to all the pods.
100100
##
101101
extraConfig: {}
102+
## @param invenio.extra_env_from_secret DEPRECATED: Use `invenio.extraEnvFrom` or `invenio.extraEnvVars` instead.
102103
extra_env_from_secret: []
103-
# - name: NAME_OF_MY_ENV_VAR
104-
# valueFrom:
105-
# secretKeyRef:
106-
# name: name-of-my-secret
107-
# key: KEY_IN_MY_SECRET
104+
## @param invenio.extraEnvVars Extra environment variables to be added to all the pods.
105+
##
106+
extraEnvVars: []
108107
uwsgiExtraConfig: {}
109108
## @param invenio.extraEnvFrom Extra secretRef or configMapRef for the `envFrom` field in all Invenio containers
110109
##
@@ -214,7 +213,7 @@ web:
214213
uwsgi:
215214
processes: 6
216215
threads: 4
217-
## @param web.extraEnvVars Extra environment variables (templated) to be added to the pods.
216+
## @param web.extraEnvVars Extra environment variables to be added to the pods.
218217
##
219218
extraEnvVars: []
220219
autoscaler:
@@ -323,7 +322,7 @@ worker:
323322
run_mount_path: /var/run/celery
324323
celery_pidfile: /var/run/celery/celerybeat.pid
325324
celery_schedule: /var/run/celery/celery-schedule
326-
## @param worker.extraEnvVars Extra environment variables (templated) to be added to the pods.
325+
## @param worker.extraEnvVars Extra environment variables to be added to the pods.
327326
##
328327
extraEnvVars: []
329328
## @param worker.resources `resources` for the worker container
@@ -374,7 +373,7 @@ worker:
374373
tolerations: []
375374

376375
workerBeat:
377-
## @param workerBeat.extraEnvVars Extra environment variables (templated) to be added to the pods.
376+
## @param workerBeat.extraEnvVars Extra environment variables to be added to the pods.
378377
##
379378
extraEnvVars: []
380379
## @param workerBeat.resources `resources` for the worker-beat container

0 commit comments

Comments
 (0)