tests: add tests for shared uploads and requests

Author: zzacharo

invenio_rdm_records/requests/community_inclusion.py

@@ -109,6 +109,7 @@ class CommunityInclusion(RequestType):
         "community_roles": ["owner", "manager", "curator"],
         "record_permission": "preview",
     }
+    resolve_topic_needs = True
 
     available_actions = {
         "create": actions.CreateAction,

invenio_rdm_records/requests/community_submission.py

@@ -189,6 +189,7 @@ class CommunitySubmission(ReviewRequest):
     allowed_creator_ref_types = ["user"]
     allowed_receiver_ref_types = ["community"]
     allowed_topic_ref_types = ["record"]
+    resolve_topic_needs = True
     needs_context = {
         "community_roles": ["owner", "manager", "curator"],
         "record_permission": "preview",

invenio_rdm_records/requests/entity_resolvers.py

@@ -69,13 +69,14 @@ def get_needs(self, ctx=None):
 
         A user that can preview a record can also read its requests.
         """
+        if ctx is None or "record_permission" not in ctx:
+            return []
+
         record = self.resolve()
-        needs = []
-        record_permission = ctx.get("record_permission")
-        if record_permission:
-            needs = current_rdm_records_service.config.permission_policy_cls(
-                record_permission, record=record
-            ).needs
+        record_permission = ctx["record_permission"]
+        needs = current_rdm_records_service.config.permission_policy_cls(
+            record_permission, record=record
+        ).needs
         return needs
 
 

invenio_rdm_records/services/access/service.py

@@ -22,7 +22,7 @@
 from invenio_notifications.services.uow import NotificationOp
 from invenio_records_resources.services.errors import PermissionDeniedError
 from invenio_records_resources.services.records.schema import ServiceSchemaWrapper
-from invenio_records_resources.services.uow import unit_of_work, RecordCommitOp
+from invenio_records_resources.services.uow import RecordCommitOp, unit_of_work
 from invenio_requests.proxies import current_requests_service
 from invenio_search.engine import dsl
 from invenio_users_resources.proxies import current_user_resources

invenio_rdm_records/services/config.py

@@ -97,8 +97,8 @@
 from .schemas.tombstone import TombstoneSchema
 from .search_params import (
     MetricsParam,
-    SharedOrMyDraftsParam,
     PublishedRecordsParam,
+    SharedOrMyDraftsParam,
     StatusParam,
 )
 from .sort import VerifiedRecordsSortParam

invenio_rdm_records/services/search_params.py

@@ -8,15 +8,14 @@
 
 """Search parameter interpreter API."""
 
-from invenio_search.engine import dsl
-
 from invenio_access.permissions import authenticated_user
 from invenio_records_resources.services.records.params.base import ParamInterpreter
+from invenio_search.engine import dsl
 
-from invenio_rdm_records.services.generators import AccessGrant
 from invenio_rdm_records.records.systemfields.deletion_status import (
     RecordDeletionStatusEnum,
 )
+from invenio_rdm_records.services.generators import AccessGrant
 
 
 class StatusParam(ParamInterpreter):

tests/resources/test_resources.py

@@ -16,6 +16,7 @@
 
 import arrow
 import pytest
+from invenio_accounts.testutils import login_user_via_session
 from invenio_requests import current_requests_service
 from marshmallow_utils.permissions import FieldPermissionError
 

tests/resources/test_serialized_links.py

@@ -57,6 +57,7 @@ def test_draft_links(client, draft_json, minimal_record, headers):
         "self": f"https://127.0.0.1:5000/api/records/{pid_value}/draft",
         "review": f"https://127.0.0.1:5000/api/records/{pid_value}/draft/review",  # noqa
         "self_html": f"https://127.0.0.1:5000/uploads/{pid_value}",
+        "preview_html": f"https://127.0.0.1:5000/records/{pid_value}?preview=1",
         "publish": f"https://127.0.0.1:5000/api/records/{pid_value}/draft/actions/publish",  # noqa
         "record": f"https://127.0.0.1:5000/api/records/{pid_value}",
         "record_html": f"https://127.0.0.1:5000/records/{pid_value}",
@@ -95,6 +96,7 @@ def test_record_links(client, published_json, headers):
     expected_links = {
         "self": f"https://127.0.0.1:5000/api/records/{pid_value}",
         "self_html": f"https://127.0.0.1:5000/records/{pid_value}",
+        "preview_html": f"https://127.0.0.1:5000/records/{pid_value}?preview=1",
         "doi": f"https://handle.stage.datacite.org/{doi_value}",
         "self_doi": f"https://handle.stage.datacite.org/{doi_value}",
         "self_doi_html": f"https://127.0.0.1:5000/doi/{doi_value}",