review: fix draft indexing operations order

slint · slint · commit 89ea407ef7f4 · 2024-04-22T10:03:14.000+02:00
* Fixes a bug where when publishing directly to a community (e.g. beacause the uplader is a community admin/owner/curator), the draft would get deleted form the index and then indexed again, thus appearing twice in the users' dashboard both as a published record and as a draft in review. * Closes #1730.
diff --git a/invenio_rdm_records/services/review/service.py b/invenio_rdm_records/services/review/service.py
@@ -183,6 +183,7 @@ def submit(self, identity, id_, data=None, require_review=False, uow=None):
         # request object
         draft.parent.review = request
         uow.register(ParentRecordCommitOp(draft.parent))
+        uow.register(RecordIndexOp(draft, indexer=self.indexer))
 
         if not require_review:
             request_item = current_rdm_records.community_inclusion_service.include(
@@ -196,5 +197,4 @@ def submit(self, identity, id_, data=None, require_review=False, uow=None):
                 )
             )
         )
-        uow.register(RecordIndexOp(draft, indexer=self.indexer))
         return request_item

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ def submit(self, identity, id_, data=None, require_review=False, uow=None):`
`183`	`183`	`# request object`
`184`	`184`	`draft.parent.review = request`
`185`	`185`	`uow.register(ParentRecordCommitOp(draft.parent))`
	`186`	`+ uow.register(RecordIndexOp(draft, indexer=self.indexer))`
`186`	`187`
`187`	`188`	`if not require_review:`
`188`	`189`	`request_item = current_rdm_records.community_inclusion_service.include(`
`@@ -196,5 +197,4 @@ def submit(self, identity, id_, data=None, require_review=False, uow=None):`
`196`	`197`	`)`
`197`	`198`	`)`
`198`	`199`	`)`
`199`		`- uow.register(RecordIndexOp(draft, indexer=self.indexer))`
`200`	`200`	`return request_item`