deposit-ui: show icon and tooltip for new error format with severity error

Author: ptamarit

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/api/DepositRecordSerializer.js

@@ -369,7 +369,7 @@ export class RDMDepositRecordSerializer extends DepositRecordSerializer {
     //                 Form/Error UX is tackled in next sprint and this is good
     //                 enough for now.
     for (const e of errors) {
-      if ("severity" in e && e.severity !== "error") {
+      if ("severity" in e && "severity" in e) {
         // New error format with severity and description
         _set(deserializedErrors, e.field, {
           message: e.messages.join(" "),

invenio_rdm_records/assets/semantic-ui/js/invenio_rdm_records/src/deposit/errors/FormFeedback.js

@@ -201,9 +201,13 @@ class DisconnectedFormFeedback extends Component {
       ...severityChecks,
     });
 
+    const noSeverityChecksWithErrors = Object.values(severityChecks).every(
+      (severityObject) => severityObject.severity !== "error"
+    );
+
     // Determine final feedback without reassigning
     const feedback =
-      errorSections && _isEmpty(flattenedErrors) && !_isEmpty(severityChecks)
+      errorSections && _isEmpty(flattenedErrors) && noSeverityChecksWithErrors
         ? "suggestive"
         : initialFeedback;