Merge pull request #319 from ipfs/fix/gateway-panic

willscott · web-flow · commit b8b39bea7728 · 2023-05-29T21:55:54.000+02:00
fix(gw): missing return in error case
diff --git a/gateway/handler_defaults.go b/gateway/handler_defaults.go
@@ -76,6 +76,7 @@ func (i *handler) serveDefaults(ctx context.Context, w http.ResponseWriter, r *h
 				if err != nil {
 					err = fmt.Errorf("failed to resolve %s: %w", debugStr(contentPath.String()), err)
 					webError(w, err, http.StatusInternalServerError)
+					return false
 				}
 			} else {
 				if !i.handleRequestErrors(w, contentPath, err) {

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,7 @@ func (i handler) serveDefaults(ctx context.Context, w http.ResponseWriter, r h`
`76`	`76`	`if err != nil {`
`77`	`77`	`err = fmt.Errorf("failed to resolve %s: %w", debugStr(contentPath.String()), err)`
`78`	`78`	`webError(w, err, http.StatusInternalServerError)`
	`79`	`+ return false`
`79`	`80`	`}`
`80`	`81`	`} else {`
`81`	`82`	`if !i.handleRequestErrors(w, contentPath, err) {`