migrations: make libc check more resilient #3665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3661. There are a couple of cases in which ldd won't operate on an executable, for example when the executable is statically linked. This patch makes the call to ldd to ldd more resilient against errors, and looks for the system libc, instead of the libc go-ipfs was linked against. License: MIT Signed-off-by: Lars Gierth <[email protected]>
ghost
added
kind/bug
ghost
requested review from
Kubuxu
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hsanjuan you should be able to build go-ipfs from this branch and copy it into the container, and it should work then.
Fixes #3661.
There are a couple of cases in which ldd won't operate on an executable,
for example when the executable is statically linked.
This patch makes the call to ldd to ldd more resilient against errors,
and looks for the system libc, instead of the libc go-ipfs was linked against.
License: MIT
Signed-off-by: Lars Gierth [email protected]