Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Commit 73d8fbb

Browse files
authored
chore: remove second greaterThanZero check from block.rm test (#2983)
This PR removes the `expect(localRefsAfterRemove).to.have.property('length').that.is.greaterThan(0)` from line 42. The rationale here is that the `rs-ipfs` nodes start with a completely empty blockstore. Once only block added is removed, then it drops back to one again. This was imo the least obtrusive move I could make with the tests, the alternative could be to seed a cid2 within the test to ensure it was always `greaterThanZero`
1 parent 6d98c92 commit 73d8fbb

File tree

1 file changed

+0
-1
lines changed
  • packages/interface-ipfs-core/src/block

1 file changed

+0
-1
lines changed

packages/interface-ipfs-core/src/block/rm.js

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ module.exports = (common, options) => {
3939

4040
// did we actually remove the block?
4141
const localRefsAfterRemove = await all(ipfs.refs.local())
42-
expect(localRefsAfterRemove).to.have.property('length').that.is.greaterThan(0)
4342
expect(localRefsAfterRemove.find(ref => ref.ref === cid.toString())).to.not.be.ok()
4443
})
4544

0 commit comments

Comments
 (0)