conifg-patch: apply review

License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>

Author: magik6k

core/commands/config.go

@@ -298,11 +298,9 @@ var configProfileApplyCmd = &cmds.Command{
 		cmds.StringArg("profile", true, false, "The profile to apply to the config."),
 	},
 	Run: func(req cmds.Request, res cmds.Response) {
-		args := req.Arguments()
-
-		profile, ok := config.Profiles[args[0]]
+		profile, ok := config.Profiles[req.Arguments()[0]]
 		if !ok {
-			res.SetError(fmt.Errorf("%s in not a profile", args[0]), cmds.ErrNormal)
+			res.SetError(fmt.Errorf("%s is not a profile", req.Arguments()[0]), cmds.ErrNormal)
 			return
 		}
 
@@ -326,11 +324,9 @@ Backing up the config before running this command is advised.`,
 		cmds.StringArg("profile", true, false, "The profile to apply to the config."),
 	},
 	Run: func(req cmds.Request, res cmds.Response) {
-		args := req.Arguments()
-
-		profile, ok := config.Profiles[args[0]]
+		profile, ok := config.Profiles[req.Arguments()[0]]
 		if !ok {
-			res.SetError(fmt.Errorf("%s in not a profile", args[0]), cmds.ErrNormal)
+			res.SetError(fmt.Errorf("%s is not a profile", req.Arguments()[0]), cmds.ErrNormal)
 			return
 		}
 

repo/config/profile.go

@@ -1,7 +1,9 @@
 package config
 
+// Transformer is a function which takes configuration and applies some filter to it
 type Transformer func(c *Config) error
 
+// Profile applies some set of changes to the configuration
 type Profile struct {
 	Apply   Transformer
 	Unapply Transformer
@@ -32,11 +34,13 @@ var Profiles = map[string]*Profile{
 				"/ip4/240.0.0.0/ipcidr/4",
 			}
 
+			c.Addresses.NoAnnounce = append(c.Addresses.NoAnnounce, defaultServerFilters...)
 			c.Swarm.AddrFilters = append(c.Swarm.AddrFilters, defaultServerFilters...)
 			c.Discovery.MDNS.Enabled = false
 			return nil
 		},
 		Unapply: func(c *Config) error {
+			c.Addresses.NoAnnounce = []string{}
 			c.Swarm.AddrFilters = []string{}
 			c.Discovery.MDNS.Enabled = true
 			return nil