Skip to content

tests: ensure kubo is providing cid only once #10784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
guillaumemichel opened this issue Apr 16, 2025 · 0 comments
Open
3 tasks done

tests: ensure kubo is providing cid only once #10784

guillaumemichel opened this issue Apr 16, 2025 · 0 comments
Labels
kind/test Testing work

Comments

@guillaumemichel
Copy link
Contributor

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

kubo is currently writing the same cid multiple times to the provide queue: ipfs/boxo#901

There used to be a mechanism to deduplicate cids before they are provided in boxo/provider, but the mechanism was removed with ipfs/boxo#907

ipfs/boxo#910 is a fix to prevent duplicate cids from being provided multiple times. However, it doubles the internal buffer size of the queue, since it uses a LRU cache to remember and filter out recently provided cids.

This fix wouldn't be required if we can test in kubo that each cid is written once to the provide queue, and only provided once.

@guillaumemichel guillaumemichel added the kind/test Testing work label Apr 16, 2025
@lidel lidel mentioned this issue Apr 22, 2025
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test Testing work
Projects
None yet
Development

No branches or pull requests

1 participant