Skip to content

ipfs log level [system] [level] is broken #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelMure opened this issue Oct 20, 2015 · 4 comments
Closed

ipfs log level [system] [level] is broken #1874

MichaelMure opened this issue Oct 20, 2015 · 4 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@MichaelMure
Copy link
Contributor

Step to reproduce:

ipfs log level all info

--> I can see some logs, bitswap included

ipfs log level all panic
ipfs log level bitswap info

--> no log shown

@whyrusleeping
Copy link
Member

thanks for reporting. This is indeed broken...

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Oct 21, 2015
@whyrusleeping whyrusleeping self-assigned this Oct 21, 2015
@whyrusleeping
Copy link
Member

@rht do you think I could get a hand on this one?

@rht
Copy link
Contributor

rht commented Oct 22, 2015

This is because there is no way to set log level threshold for each logrus.Entry.
Creating a new logger (instead of entry) for each module won't do, since logger doesn't store fields.

Though here is one way to do it (fork logrus.Entry to contain threshold field) rht@9e26753.

@whyrusleeping
Copy link
Member

i think this has been fixed, we don't use logrus anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

3 participants