Skip to content

Pubsub returns wrong peers for a topic #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
haadcode opened this issue Dec 5, 2016 · 3 comments · Fixed by #3484
Closed

Pubsub returns wrong peers for a topic #3467

haadcode opened this issue Dec 5, 2016 · 3 comments · Fixed by #3484
Assignees
@whyrusleeping
Labels
kind/bug A bug in existing code (including security flaws)
Milestone
ipfs 0.4.5

Comments

@haadcode
Copy link
Member

haadcode commented Dec 5, 2016

Version information:

0.4.5-pre1

Type:

Bug

Description:

When I call pubsub/peers(topic), go-ipfs returns all peers that are connected to it. Expected behaviour is to return only the ones that are subscribed to the specified topic.
@haadcode haadcode added the kind/bug A bug in existing code (including security flaws) label Dec 5, 2016
@haadcode
Copy link
Member Author

haadcode commented Dec 5, 2016

@keks care to take a look?

@whyrusleeping whyrusleeping added this to the ipfs 0.4.5 milestone Dec 5, 2016
@Kubuxu Kubuxu added the status/in-progress In progress label Dec 5, 2016
@whyrusleeping whyrusleeping mentioned this issue Dec 8, 2016
Merged
@whyrusleeping whyrusleeping self-assigned this Dec 8, 2016
@keks
Copy link
Contributor

keks commented Dec 9, 2016

Oh dang, sorry for not responding! Was really busy with uni stuff this week. I'll take a look on Monday!

@Kubuxu
Copy link
Member

Kubuxu commented Dec 9, 2016 •
edited by haadcode
Loading

There is PR made by @whyrusleeping for this already: #3484

@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whyrusleeping whyrusleeping

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
ipfs 0.4.5
Development

Successfully merging a pull request may close this issue.

cmd/pubsub: fix peers command topic filtering ipfs/kubo
4 participants
@keks @whyrusleeping @Kubuxu @haadcode