ipfs version --commit no longer shows githash

[eminence]

Version information:

$ ipfs version --all
go-ipfs version: 0.4.8-rc1-
Repo version: 5
System version: amd64/linux
Golang version: go1.7.1

Type: Bug

Priority: P3

Description:

Running ipfs version --commit or ipfs version --all no longer shows the git hash. In my case, I am building ipfs from source by running "make install" from my $GOPATH/src/github.com/ipfs/go-ipfs directory. See above for an example. I bisected this, and this problem was introduced by f630222

[Kubuxu]

Works here.

 cmd/ipfs/ipfs version --commit
ipfs version 0.4.8-rc1-a8b56d3ad

f630222 introduced it but it was latter resolved in same PR (iirc). As a note, builds from dist.ipfs.io don't have the hash.

[ghost]

As a note, builds from dist.ipfs.io don't have the hash.

Why? They used to

[Kubuxu]

I don't think they ever had a hash.

[eminence]

Here's a more complete transcript on my build session:

achin@bigbox ~/devel/gopath/src/github.com/ipfs/go-ipfs $ git clean -dfx
Skipping repository test/sharness/lib/sharness/

achin@bigbox ~/devel/gopath/src/github.com/ipfs/go-ipfs $ git show -s |cat
commit a8b56d3ad7789ca2ec12257a00d8d0408c3c0c9e
Author: Jeromy <[email protected]>
Date:   Fri Mar 24 20:34:49 2017 -0700

    Ipfs 0.4.8-rc1

    License: MIT
    Signed-off-by: Jeromy <[email protected]>



achin@bigbox ~/devel/gopath/src/github.com/ipfs/go-ipfs $ make install
bin/check_go_version 1.7
bin/check_go_path /storage/home/achin/devel/gopath/src/github.com/ipfs/go-ipfs /storage/home/achin/devel/gopath/src/github.com/ipfs/go-ipfs
installing gx v0.11.0
bin/dist_get /ipfs/QmNjXP6N98fYT1i7abgeBHmdR5WoeBeik4DtGiX9iFWK31 gx bin/gx-v0.11.0 v0.11.0
==> Using wget to download "https://ipfs.io/ipfs/QmNjXP6N98fYT1i7abgeBHmdR5WoeBeik4DtGiX9iFWK31/gx/v0.11.0/gx_v0.11.0_linux-amd64.tar.gz" to "bin/tmp/gx.tar.gz"
--2017-03-27 09:00:41--  https://ipfs.io/ipfs/QmNjXP6N98fYT1i7abgeBHmdR5WoeBeik4DtGiX9iFWK31/gx/v0.11.0/gx_v0.11.0_linux-amd64.tar.gz
Resolving ipfs.io... 178.62.158.247, 104.236.179.241, 104.236.176.52, ...
Connecting to ipfs.io|178.62.158.247|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2850221 (2.7M) [application/x-gzip]
Saving to: ‘bin/tmp/gx.tar.gz’

bin/tmp/gx.tar.gz                           100%[===========================================================================================>]   2.72M  1.95MB/s    in 1.4s

2017-03-27 09:00:43 (1.95 MB/s) - ‘bin/tmp/gx.tar.gz’ saved [2850221/2850221]

==> Download complete!
==> using 'tar' to extract binary from archive
rm -f bin/gx
ln -s gx-v0.11.0 bin/gx
installing gx-go v1.4.0
==> Using wget to download "https://ipfs.io/ipfs/QmNjXP6N98fYT1i7abgeBHmdR5WoeBeik4DtGiX9iFWK31/gx-go/v1.4.0/gx-go_v1.4.0_linux-amd64.tar.gz" to "bin/tmp/gx-go.tar.gz"
--2017-03-27 09:00:43--  https://ipfs.io/ipfs/QmNjXP6N98fYT1i7abgeBHmdR5WoeBeik4DtGiX9iFWK31/gx-go/v1.4.0/gx-go_v1.4.0_linux-amd64.tar.gz
Resolving ipfs.io... 104.236.151.122, 178.62.61.185, 162.243.248.213, ...
Connecting to ipfs.io|104.236.151.122|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 3088857 (2.9M) [application/x-gzip]
Saving to: ‘bin/tmp/gx-go.tar.gz’

bin/tmp/gx-go.tar.gz                        100%[===========================================================================================>]   2.95M  4.66MB/s    in 0.6s

2017-03-27 09:00:44 (4.66 MB/s) - ‘bin/tmp/gx-go.tar.gz’ saved [3088857/3088857]

==> Download complete!
==> using 'tar' to extract binary from archive
rm -f bin/gx-go
ln -s gx-go-v1.4.0 bin/gx-go
gx install --global
installation of dep go-logging complete!
installation of dep go-log complete!
installation of dep go-randbuf complete!
installation of dep go-msgio complete!
installation of dep go-crypto complete!
installation of dep go-base58 complete!
installation of dep go-multihash complete!
installation of dep go-base58 complete!
installation of dep go-ipfs-util complete!
installation of dep gogo-protobuf complete!
installation of dep ed25519 complete!
installation of dep btcec complete!
installation of dep go-libp2p-crypto complete!
installation of dep go-libp2p-peer complete!
installation of dep go-libp2p-secio complete!
installation of dep go-libp2p-crypto complete!
installation of dep go-libp2p-peer complete!
installation of dep goprocess complete!
installation of dep gogo-protobuf complete!
installation of dep protobuf complete!
installation of dep client_model complete!
installation of dep procfs complete!
installation of dep httprouter complete!
installation of dep golang_protobuf_extensions complete!
installation of dep go-text complete!
installation of dep go-net complete!
installation of dep common complete!
installation of dep go-net complete!
installation of dep perks complete!
installation of dep client_golang complete!
installation of dep keccakpg complete!
installation of dep murmur3 complete!
installation of dep go-multihash complete!
installation of dep go-multiaddr complete!
installation of dep go-multiaddr-net complete!
installation of dep yaml.v2 complete!
installation of dep cli complete!
installation of dep stump complete!
installation of dep go-ctrlnet complete!
installation of dep iptb complete!
installation of dep go-multihash complete!
installation of dep go.uuid complete!
installation of dep hamming complete!
installation of dep backoff complete!
installation of dep proquint complete!
installation of dep go-colorable complete!
installation of dep pb complete!
installation of dep go-context complete!
installation of dep xhandler complete!
installation of dep cors complete!
installation of dep go-humanize complete!
installation of dep atomicfile complete!
installation of dep snappy complete!
installation of dep goleveldb complete!
installation of dep go-sysinfo complete!
installation of dep sys complete!
installation of dep fsnotify.v1 complete!
installation of dep go-datastore complete!
installation of dep hdrhistogram complete!
installation of dep metrics complete!
installation of dep golang-lru complete!
installation of dep sys complete!
installation of dep lock complete!
installation of dep go-multiaddr complete!
installation of dep go-keyspace complete!
installation of dep go-multiaddr-net complete!
installation of dep mafmt complete!
installation of dep go-libp2p-peerstore complete!
installation of dep base32 complete!
installation of dep bbloom complete!
installation of dep go-is-domain complete!
installation of dep failstore complete!
installation of dep retry-datastore complete!
installation of dep failstore complete!
installation of dep go-semver complete!
installation of dep dns complete!
installation of dep mdns complete!
installation of dep go-multistream complete!
installation of dep go-detect-race complete!
installation of dep multiaddr-filter complete!
installation of dep go-metrics complete!
installation of dep randbo complete!
installation of dep go-notifier complete!
installation of dep go-temp-err-catcher complete!
installation of dep go-stream-muxer complete!
installation of dep go-libp2p-protocol complete!
installation of dep go-libp2p-transport complete!
installation of dep go-peerstream complete!
installation of dep gorocheck complete!
installation of dep go-libp2p-loggables complete!
installation of dep websocket complete!
installation of dep ws-transport complete!
installation of dep go-libp2p-transport complete!
installation of dep go-sockaddr complete!
installation of dep go-net-resolve-addr complete!
installation of dep GoEndian complete!
installation of dep eventfd complete!
installation of dep go-reuseport complete!
installation of dep go-tcp-transport complete!
installation of dep go-maddr-filter complete!
installation of dep go-libp2p-protocol complete!
installation of dep go-addr-util complete!
installation of dep go-testutil complete!
installation of dep go-libp2p-interface-conn complete!
installation of dep go-libp2p-interface-pnet complete!
installation of dep go-libp2p-conn complete!
installation of dep go-libp2p-net complete!
installation of dep go-libp2p-metrics complete!
installation of dep go-libp2p-interface-conn complete!
installation of dep go-libp2p-host complete!
installation of dep spdystream complete!
installation of dep go-smux-spdystream complete!
installation of dep go-smux-multistream complete!
installation of dep yamux complete!
installation of dep go-smux-yamux complete!
installation of dep go-libp2p-swarm complete!
installation of dep goupnp complete!
installation of dep gateway complete!
installation of dep go-nat-pmp complete!
installation of dep go-nat complete!
installation of dep go-libp2p-nat complete!
installation of dep go-libp2p-netutil complete!
installation of dep go-libp2p-blankhost complete!
installation of dep go-libp2p complete!
installation of dep go-multibase complete!
installation of dep go-cid complete!
installation of dep go-os-rename complete!
installation of dep go-ds-flatfs complete!
installation of dep go-metrics-interface complete!
installation of dep go-ds-measure complete!
installation of dep go-ds-leveldb complete!
installation of dep go-libp2p-loggables complete!
installation of dep go-metrics-prometheus complete!
installation of dep go-metrics-interface complete!
installation of dep autobatch complete!
installation of dep go-libp2p-record complete!
installation of dep go-libp2p-kbucket complete!
installation of dep go-libp2p-routing complete!
installation of dep go-todocounter complete!
installation of dep go-libp2p-kad-dht complete!
installation of dep hang-fds complete!
installation of dep timecache complete!
installation of dep floodsub complete!
installation of dep go-ipld-node complete!
installation of dep cbor complete!
installation of dep go-ipld-cbor complete!
installation of dep dir-index-html complete!
installation of dep go-os-helper complete!
installation of dep go-multiplex complete!
installation of dep go-smux-multiplex complete!
installation of dep semver complete!
installation of dep bufpipe complete!
installation of dep go-libp2p-dummy-conn complete!
installation of dep cbor complete!
installation of dep go-multicodec complete!
installation of dep go-crypto-dav complete!
installation of dep go-libp2p-pnet complete!
installation of dep sys complete!
installation of dep fuse complete!
installation of dep murmur3 complete!
installation of dep go-ipfs complete!
go install  ./cmd/ipfs

achin@bigbox ~/devel/gopath/src/github.com/ipfs/go-ipfs $ echo $GOPATH
/storage/home/achin/devel/gopath

achin@bigbox ~/devel/gopath/src/github.com/ipfs/go-ipfs $ which ipfs
/storage/home/achin/devel/gopath/bin/ipfs

achin@bigbox ~/devel/gopath/src/github.com/ipfs/go-ipfs $ /storage/home/achin/devel/gopath/bin/ipfs version --commit
ipfs version 0.4.8-rc1-

[Kubuxu]

Aaah, make install. Fixing as we speak.

[whyrusleeping]

As a note, builds from dist.ipfs.io don't have the hash.

This is because of the dists build process. I can probably fix it, but i've purposfully kept it this way because it makes release builds much more easily recognizeable.

If we're wanting to fix this, i can do so