[#1769] Added a test case

Author: msiodelski

backend/server/dnsop/manager_test.go

@@ -284,6 +284,78 @@ func TestFetchZonesInventoryOtherError(t *testing.T) {
 	require.Empty(t, zones)
 }
 
+// This test verifies that an error is returned indicating the database error
+// while deleting local zones before inserting new ones.
+func TestFetchZonesInventoryDeleteLocalZonesError(t *testing.T) {
+	db, _, teardown := dbtest.SetupDatabaseTestCase(t)
+	defer teardown()
+
+	controller := gomock.NewController(t)
+	mock := NewMockConnectedAgents(controller)
+
+	randomZones := testutil.GenerateRandomZones(1)
+
+	// Add a machine and app.
+	machine := &dbmodel.Machine{
+		ID:        0,
+		Address:   "localhost",
+		AgentPort: int64(8080),
+	}
+	err := dbmodel.AddMachine(db, machine)
+	require.NoError(t, err)
+
+	app := &dbmodel.App{
+		ID:        0,
+		MachineID: machine.ID,
+		Type:      dbmodel.AppTypeBind9,
+		Daemons: []*dbmodel.Daemon{
+			dbmodel.NewBind9Daemon(true),
+		},
+	}
+	_, err = dbmodel.AddApp(db, app)
+	require.NoError(t, err)
+
+	// Return "uninitialized" error on first iteration.
+	mock.EXPECT().ReceiveZones(gomock.Any(), gomock.Cond(func(a any) bool {
+		return a.(*dbmodel.App).ID == app.ID
+	}), nil).DoAndReturn(func(context.Context, *dbmodel.App, *bind9stats.ZoneFilter) iter.Seq2[*bind9stats.ExtendedZone, error] {
+		return func(yield func(*bind9stats.ExtendedZone, error) bool) {
+			// We are on the fist iteration. Let's close the database connection
+			// to cause an error.
+			teardown()
+			// Return the zone.
+			zone := &bind9stats.ExtendedZone{
+				Zone: bind9stats.Zone{
+					ZoneName: randomZones[0].Name,
+					Class:    randomZones[0].Class,
+					Serial:   randomZones[0].Serial,
+					Type:     randomZones[0].Type,
+					Loaded:   time.Now().UTC(),
+				},
+				ViewName:       "foo",
+				TotalZoneCount: int64(len(randomZones)),
+			}
+			_ = yield(zone, nil)
+		}
+	})
+	require.NoError(t, err)
+
+	manager := NewManager(&appstest.ManagerAccessorsWrapper{
+		DB:     db,
+		Agents: mock,
+	})
+	require.NotNil(t, manager)
+
+	notifyChannel, err := manager.FetchZones(10, 100, true)
+	require.NoError(t, err)
+	notification := <-notifyChannel
+
+	// Make sure other error was reported.
+	require.Len(t, notification.results, 1)
+	require.NotNil(t, notification.results[app.Daemons[0].ID].Error)
+	require.Contains(t, *notification.results[app.Daemons[0].ID].Error, "database is closed")
+}
+
 // This test verifies that the manager can fetch zones from many servers
 // simultaneously.
 func TestFetchZones(t *testing.T) {