Skip to content

Salary Request #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TallData opened this issue Sep 22, 2020 · 3 comments · May be fixed by #314
Open

Salary Request #205

TallData opened this issue Sep 22, 2020 · 3 comments · May be fixed by #314

Comments

@TallData
Copy link

Can you add salary? Working on some player efficiency models and want to take that into account. Contract info for 2019 season attached below.

https://www.basketball-reference.com/contracts/players.html
@jaebradley
Copy link
Owner

@TallData definitely a reasonable request - is it necessary that the different "option" types be reported as part of the salary information?

image

@TallData
Copy link
Author

That would be good to add. You took my request a step further. Should provide good insight seeing what type of signing it was.

@chaosprint
Copy link

any plan on this?

@jaebradley jaebradley linked a pull request Mar 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support parsing the player contracts page jaebradley/basketball_reference_web_scraper
3 participants
@TallData @jaebradley @chaosprint