Skip to content

Commit 29c4972

Browse files
laydayjaraco
authored andcommitted
Require toml extra for setuptools_scm (#12)
* Require toml extra for setuptools_scm setuptools_scm does not know to invoke itself if it can't read pyproject.toml. This broke sdist installs for projects deriving from skeleton: $ python -m pip install zipp --no-binary zipp Collecting zipp [...] Successfully installed zipp-0.0.0 Note the version number defaulting to '0.0.0'. Building locally only works because pep517, the build tool, depends on toml which it exposes to the build environment. * Require setuptools_scm 3.4.1 at a minimum A bare [tool.setuptools_scm] does not work in 3.4.0. * fixup! Require toml extra for setuptools_scm * fixup! Require setuptools_scm 3.4.1 at a minimum
1 parent 479ac21 commit 29c4972

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[build-system]
2-
requires = ["setuptools>=42", "wheel", "setuptools_scm>=3.4"]
2+
requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.4.1"]
33
build-backend = "setuptools.build_meta"
44

55
[tool.black]

setup.cfg

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ packages = find:
1818
include_package_data = true
1919
python_requires = >=3.6
2020
install_requires =
21-
setup_requires = setuptools_scm >= 3.4
21+
setup_requires = setuptools_scm[toml] >= 3.4.1
2222

2323
[options.extras_require]
2424
testing =

0 commit comments

Comments
 (0)